From bddd6ce3aa992d513f5f430d5c2434d18a124ebe Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Fri, 19 Jan 2024 15:27:24 +0000 Subject: [PATCH] Bug 35840: Only AddReturn if item is onloan To test: 1. APPLY PATCH, restart_all 2. Turn on RecordLocalUseOnReturn 3. Create a Statistical patron. 4. Check an item out to a regular patron. 5. Check the item out to a Statistical patron. 6. This should trigger a return and you will see 2 entries in the statistics table, one for localuse and one for a return. 7. Try checking out an item to the Stats patron that is NOT checked out. 8. You should only see 1 entry, localuse, in the statistics table. --- C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 109809d4b9..81b7a30627 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -836,7 +836,7 @@ sub CanBookBeIssued { ); my $block_lost_return = C4::Context->preference("BlockReturnOfLostItems") ? 1 : 0; my ( $stats_return, $stats_messages, $stats_iteminformation, $stats_borrower ) = - AddReturn( $item_object->barcode, C4::Context->userenv->{'branch'} ); + AddReturn( $item_object->barcode, C4::Context->userenv->{'branch'} ) unless !$item_object->onloan; ModDateLastSeen( $item_object->itemnumber, $block_lost_return ); # FIXME Move to Koha::Item return ( { -- 2.30.2