From 70ebd5376870a63df1817a6801caff17e913ca89 Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Wed, 17 Jan 2024 15:45:53 +0000 Subject: [PATCH] Bug 35535: Allow for cancellation of holds with or without a reason TO TEST: 1. Have a waiting hold on a particular barcode 2. Have at least 1 HOLD_CANCELLATION auth value 3. Check in the barcode and try to cancel the hold on the modal while selecting a reason. => SUCCESS: You can cancel a hold when selecting a reason. 4. Repeat 1-3 but not selecting any reason. => SUCCESS: Hold cancelled correctly. 5. Delete all HOLD_CANCELLATION auth values. 6. Repeat Try 1-3 => SUCCESS: No reason displayed => FAIL: Cancelling does nothing. There's an error in the browser inspector 7. Apply this patch 8. Repeat 1-3 => SUCCESS: No reason displayed => SUCCESS: Cancelling works 9. Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi Edit: amended the test plan to make it clearer --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt index 2abde7f9c5a..cbf476b0d36 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ -705,7 +705,7 @@ [% SET hold_cancellation = AuthorisedValues.GetAuthValueDropbox('HOLD_CANCELLATION') %] [% IF hold_cancellation.count %]