From fbc58d5359c67e98a283d0e313c49cc5eae99b3e Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 29 Jan 2024 10:41:56 +0100 Subject: [PATCH] Bug 34913: Fix perlcritic for VirtualShelves.pm C4/Utils/DataTables/VirtualShelves.pm: "@order_by" is declared but not used at line 86, column 9. Unused variables clutter code and make it harder to read. (Severity: 3) --- C4/Utils/DataTables/VirtualShelves.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/C4/Utils/DataTables/VirtualShelves.pm b/C4/Utils/DataTables/VirtualShelves.pm index 8100a65591d..2c4c1628e18 100644 --- a/C4/Utils/DataTables/VirtualShelves.pm +++ b/C4/Utils/DataTables/VirtualShelves.pm @@ -83,7 +83,6 @@ sub search { if ($order_by) { - my @order_by; $order_by =~ s|shelfnumber|vs.shelfnumber|; my @sanitized_orderbys; for my $order ( split ',', $order_by ) { -- 2.34.1