From 6aaa4b4968898326f92709ec35a42ef561921926 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 30 Jan 2024 09:02:19 +0100
Subject: [PATCH] Bug 35935: Ensure login branch will be used after incorrect
 login

If a different branch is selected after an incorrect login, the previous branch will be used.

To recreate:
* login with foo/bar, select CPL => FAIL
* login with koha/koha, select another branch => OK but CPL is picked!

It was caused by a dup of "branch" in CGI param list (and first was picked).

This patch patch also removes "koha_login_context" to not have it twice.
You can also open the source of the page to confirm that form#loginform
contains "branch" and "koha_login_context" in hidden inputs.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Tested in KTD. Works as advertised.
---
 koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
index 14e30e5e6e..1d2472ab33 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
@@ -124,6 +124,8 @@
     <form action="[% script_name | html %]" method="post" name="loginform" id="loginform" class="validated">
         <input type="hidden" name="koha_login_context" value="intranet" />
     [% FOREACH INPUT IN INPUTS %]
+        [% NEXT IF INPUT.name == "koha_login_context" %]
+        [% NEXT IF INPUT.name == "branch" %]
         <input type="hidden" name="[% INPUT.name | html %]" value="[% INPUT.value | html %]" />
     [% END %]
     <p><label for="userid">Username:</label>
-- 
2.34.1