Bugzilla – Attachment 162016 Details for
Bug 10758
acqui/basket: Show bibliographic information of deleted records
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10758: Show title of deleted biblio on basket page
Bug-10758-Show-title-of-deleted-biblio-on-basket-p.patch (text/plain), 3.65 KB, created by
Marcel de Rooy
on 2024-02-12 08:22:54 UTC
(
hide
)
Description:
Bug 10758: Show title of deleted biblio on basket page
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-02-12 08:22:54 UTC
Size:
3.65 KB
patch
obsolete
>From 8e29ed4b65b59df56b7203a8755e244dead32c0a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 12 Feb 2024 08:01:26 +0000 >Subject: [PATCH] Bug 10758: Show title of deleted biblio on basket page >Content-Type: text/plain; charset=utf-8 > >Test plan: >Find a completed order line and a cancelled one with deleted biblios. >Goto acqui/basket.pl >Check if you see the title if deleted_biblionumber is filled. >--- > acqui/basket.pl | 4 +++- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 6 ++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > >diff --git a/acqui/basket.pl b/acqui/basket.pl >index 33253aad47..ac444a6f09 100755 >--- a/acqui/basket.pl >+++ b/acqui/basket.pl >@@ -41,6 +41,7 @@ use Koha::CsvProfiles; > use Koha::Patrons; > > use Koha::AdditionalFields; >+use Koha::Old::Biblios; > > =head1 NAME > >@@ -500,7 +501,8 @@ sub get_order_infos { > $line{holds_on_order} = $itemholds ? $itemholds : $holds_count if $line{left_holds_on_order}; > $line{order_object} = $order; > $line{invoice_object} = $invoice; >- >+ } else { >+ $line{deleted_biblio} = Koha::Old::Biblios->find( $order->{deleted_biblionumber} ); > } > > my $suggestion = GetSuggestionInfoFromBiblionumber($line{biblionumber}); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 21c0351f1a..a6141fe161 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -573,6 +573,9 @@ > [% IF ( books_loo.order_received ) %] <span class="order-received">(received)</span>[% END %] > [% IF books_loo.title %] > [% INCLUDE 'biblio-title.inc' biblio=books_loo link = 1 %] [% IF books_loo.author %] by [% books_loo.author | html %][% END %] >+ [% ELSIF books_loo.deleted_biblio %] >+ [% INCLUDE 'biblio-title.inc' biblio=books_loo.deleted_biblio %] >+ <br/>(Deleted bibliographic record) > [% ELSE %] > <em>Deleted bibliographic record, can't find title</em><br /> > [%- END %] >@@ -764,6 +767,9 @@ > [% IF ( order.order_received ) %] <span class="order-received">(received)</span>[% END %] > [% IF (order.title) %] > [% order.title | html %][% IF order.author %] by [% order.author | html %][% END %] >+ [% ELSIF order.deleted_biblio %] >+ [% INCLUDE 'biblio-title.inc' biblio=order.deleted_biblio %] >+ <br/>(Deleted bibliographic record) > [% ELSE %] > <em>Deleted bibliographic record, can't find title</em> > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10758
:
21296
|
22106
|
26830
|
26832
|
27273
|
27312
|
27313
|
27314
|
27315
|
28514
|
28515
|
29667
|
30551
|
30552
|
30623
|
95782
|
162016
|
162034
|
165229