From f824addb489de79a2bbe8ebcc9ca92402f332ec3 Mon Sep 17 00:00:00 2001
From: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
Date: Thu, 8 Feb 2024 11:20:38 +1300
Subject: [PATCH] Bug 35953: Add delete_any_record cataloguing subpermission

To test:
- apply patch
- create a new test user
- give the test user "catalogue" permissions so that they can enter the staff interface
- also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission
- login to the staff interface as the test user
- do a catalogue search
- click on a result and go to their biblio details page
- notice there is an "Edit" button dropdown
- click on the "Edit" button dropdown and notice there is no option to "Delete record"
- change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission
- do another catalogue search and click on the result
- click on the "Edit" button dropdown and notice there is now an option to "Delete record"

Sponsored-by: Education Services Australia SCIS
---
 .../bug_35953_-_add_delete_any_record_permission.perl       | 6 ++++++
 installer/data/mysql/mandatory/userpermissions.sql          | 1 +
 koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc    | 6 ++++++
 koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc    | 4 ++++
 4 files changed, 17 insertions(+)
 create mode 100644 installer/data/mysql/atomicupdate/bug_35953_-_add_delete_any_record_permission.perl

diff --git a/installer/data/mysql/atomicupdate/bug_35953_-_add_delete_any_record_permission.perl b/installer/data/mysql/atomicupdate/bug_35953_-_add_delete_any_record_permission.perl
new file mode 100644
index 00000000000..6ce64928b40
--- /dev/null
+++ b/installer/data/mysql/atomicupdate/bug_35953_-_add_delete_any_record_permission.perl
@@ -0,0 +1,6 @@
+$DBversion = 'XXX';
+if( CheckVersion( $DBversion ) ) {
+    $dbh->do(q{INSERT IGNORE INTO permissions (module_bit, code, description) VALUES (9, 'delete_any_record', 'Delete any existing record')});
+
+    NewVersion( $DBversion, undef, "Add delete_any_record user permission" );
+}
diff --git a/installer/data/mysql/mandatory/userpermissions.sql b/installer/data/mysql/mandatory/userpermissions.sql
index 729c075548a..555bc6ad1e4 100644
--- a/installer/data/mysql/mandatory/userpermissions.sql
+++ b/installer/data/mysql/mandatory/userpermissions.sql
@@ -59,6 +59,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES
    ( 9, 'delete_all_items', 'Delete all items at once'),
    ( 9, 'manage_item_groups', 'Create, update and delete item groups, add or remove items from a item groups'),
    ( 9, 'manage_item_editor_templates', 'Update and delete item editor template owned by others'),
+   ( 9, 'delete_any_record', 'Delete any existing record'),
    ( 9, 'edit_any_item', 'Edit any item regardless of home library'),
    (10, 'payout', 'Perform account payout action'),
    (10, 'refund', 'Perform account refund action'),
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
index 8bae4385197..cbf300b812e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
@@ -74,11 +74,17 @@
 
             [% IF CAN_user_editcatalogue_edit_catalogue or ( frameworkcode == 'FA' and CAN_user_editcatalogue_fast_cataloging ) %]
                 [% IF ( count ) %]
+                  [% IF CAN_user_editcatalogue_delete_any_record %]
                     <li class="disabled"><a id="deletebiblio" data-toggle="tooltip" data-placement="left" title="[% count | html %] item(s) are attached to this record. You must delete all items before deleting this record." href="#">Delete record</a></li>
+                  [% END %]
                 [% ELSIF ( biblio.subscriptions.count ) %]
+                  [% IF CAN_user_editcatalogue_delete_any_record %]
                     <li class="disabled"><a id="deletebiblio" data-toggle="tooltip" data-placement="left" title="[% biblio.subscriptions.count | html %] subscription(s) are attached to this record. You must delete all subscriptions before deleting this record." href="#">Delete record</a></li>
+                  [% END %]
                 [% ELSE %]
+                  [% IF CAN_user_editcatalogue_delete_any_record %]
                     <li><a id="deletebiblio" data-order-manage="[% CAN_user_acquisition_order_manage | html %]" href="#">Delete record</a></li>
+                  [% END %]
                 [% END %]
             [% END %]
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
index 742e6e1c359..caa9aa2185e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
@@ -376,6 +376,10 @@
         <span class="sub_permission fast_cataloging_subpermission">
             Fast cataloging
         </span>
+    [%- CASE 'delete_any_record' -%]
+        <span class="sub_permission delete_any_record_subpermission">
+            Delete any existing record
+        </span>
         <span class="permissioncode">([% name | html %])</span>
     [%- CASE 'manage_item_groups' -%]
         <span class="sub_permission manage_item_groups_subpermission">
-- 
2.30.2