Bugzilla – Attachment 162180 Details for
Bug 23415
Notify patron fines when renewing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23415: (QA follow-up) Fix rebase code re-introduction
Bug-23415-QA-follow-up-Fix-rebase-code-re-introduc.patch (text/plain), 3.85 KB, created by
Martin Renvoize
on 2024-02-15 08:04:24 UTC
(
hide
)
Description:
Bug 23415: (QA follow-up) Fix rebase code re-introduction
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2024-02-15 08:04:24 UTC
Size:
3.85 KB
patch
obsolete
>From 8fce14ee5b3adc0151b53625f3ca570751c70ac7 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 15 Feb 2024 07:57:46 +0000 >Subject: [PATCH] Bug 23415: (QA follow-up) Fix rebase code re-introduction > >Looks like some code was re-introduced during rebases, this patch >switches it back to calling the newly introduced 'renew' function rather >than doing the post inline. I also compared the two posts and updated >the function to match the updated post from upstream. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 43 ++------------------ > 1 file changed, 3 insertions(+), 40 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index ffe9547ee96..6a53e652839 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -674,46 +674,6 @@ $(document).ready(function() { > params.date_due = dueDate > } > >- $.post({ >- url: "/cgi-bin/koha/svc/renew", >- data: params, >- success: function( data ) { >- var id = "#renew_" + data.itemnumber; >- >- var content = ""; >- if ( data.renew_okay ) { >- content = __("Renewed, due:") + " " + data.date_due; >- $('#date_due_' + data.itemnumber).replaceWith( data.date_due ); >- } else { >- content = __("Renew failed:") + " "; >- if ( data.error == "no_checkout" ) { >- content += __("not checked out"); >- } else if ( data.error == "too_many" ) { >- content += __("too many renewals"); >- } else if ( data.error == "too_unseen" ) { >- content += __("too many consecutive renewals without being seen by the library"); >- } else if ( data.error == "on_reserve" ) { >- content += __("on hold"); >- } else if ( data.error == "restriction" ) { >- content += __("Not allowed: patron restricted"); >- } else if ( data.error == "overdue" ) { >- content += __("Not allowed: overdue"); >- } else if ( data.error == 'no_open_days' ) { >- content += __('Unable to find an open day'); >- } else if ( data.error ) { >- content += data.error; >- } else { >- content += __("reason unknown"); >- } >- refresh_table = false; >- } >- >- $(id).replaceWith( content ); >- }, >- dataType: "json", >- async: false, >- }); >- > $(this).parent().parent().replaceWith("<img id='renew_" + itemnumber + "' src='" + interface + "/" + theme + "/img/spinner-small.gif' />"); > renew(params); > }); >@@ -755,11 +715,14 @@ $(document).ready(function() { > content += __("Not allowed: patron restricted"); > } else if ( data.error == "overdue" ) { > content += __("Not allowed: overdue"); >+ } else if ( data.error == 'no_open_days' ) { >+ content += __('Unable to find an open day'); > } else if ( data.error ) { > content += data.error; > } else { > content += __("reason unknown"); > } >+ refresh_table = false; > } > > $(id).replaceWith( content ); >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23415
:
92039
|
92541
|
98442
|
98634
|
98996
|
98997
|
105893
|
105894
|
108392
|
109871
|
109872
|
109876
|
109880
|
116919
|
116920
|
116921
|
116922
|
118175
|
118176
|
118177
|
118178
|
118183
|
119300
|
119301
|
119302
|
119303
|
121472
|
139670
|
139671
|
139672
|
139673
|
139674
|
146415
|
148198
|
148199
|
148200
|
148201
|
148202
|
152776
|
152777
|
152778
|
152779
|
152780
|
152781
|
154595
|
154596
|
154597
|
154598
|
154599
|
154600
|
158302
|
158303
|
158304
|
158305
|
158306
|
158307
|
161964
|
161965
|
161966
|
161967
|
161968
|
161969
|
162171
|
162172
|
162173
|
162174
|
162175
|
162176
|
162177
|
162178
|
162179
| 162180