Bugzilla – Attachment 162492 Details for
Bug 36103
Remove the "Cancel hold" link for item level holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36103: Remove cancel-hold class
Bug-36103-Remove-cancel-hold-class.patch (text/plain), 2.35 KB, created by
Pedro Amorim
on 2024-02-27 11:03:04 UTC
(
hide
)
Description:
Bug 36103: Remove cancel-hold class
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-02-27 11:03:04 UTC
Size:
2.35 KB
patch
obsolete
>From 1e1e14179d25374359d3f51824d2d4abdca782cc Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 27 Feb 2024 11:02:15 +0000 >Subject: [PATCH] Bug 36103: Remove cancel-hold class > >1. Open the "Holds" tab of a record with an item level hold. >2. Select a patron from the patron search. >3. Click on the "Cancel hold" link. (Link appears as it should, e.g. "modrequest.pl?CancelBiblioNumber=58&CancelBorrowerNumber=5&CancelItemnumber=125"). >4. Popup appears. Click "Confirm cancellation". >5. Page loads. Instead of the correct data for the hold to cancel, all of the values in the URL are null, i.e. "request.pl?action=cancel&borrowernumber=undefined&biblionumber=undefined&reserve_id=undefined". The hold is not cancelled. >6. Apply patch. Repeat. Notice it now cancels the hold as expected. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 025d5b0ca15..c01916097ae 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -874,7 +874,7 @@ > <span>On hold expected at [% Branches.GetName( itemloo.ExpectedAtLibrary ) | html %]</span> > [% END %] > [% END %] >- <a class="info cancel-hold" href="modrequest.pl?CancelBiblioNumber=[% itemloo.biblionumber | html %]&CancelBorrowerNumber=[% itemloo.ReservedFor.borrowernumber | html %]&CancelItemnumber=[% itemloo.itemnumber | html %]">Cancel hold</a> >+ <a class="info" href="modrequest.pl?CancelBiblioNumber=[% itemloo.biblionumber | html %]&CancelBorrowerNumber=[% itemloo.ReservedFor.borrowernumber | html %]&CancelItemnumber=[% itemloo.itemnumber | html %]">Cancel hold</a> > [% END # /IF itemloo.nocancel %] > [% ELSE %] > Not on hold >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36103
:
162492
|
162502
|
162504
|
162513