Bugzilla – Attachment 162707 Details for
Bug 36076
paycollect.tt is missing permission checks for manual credit and invoice
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36076: paycollect.tt add permission checks for manual credit and invoice
Bug-36076-paycollecttt-add-permission-checks-for-m.patch (text/plain), 2.75 KB, created by
Victor Grousset/tuxayo
on 2024-03-03 22:30:19 UTC
(
hide
)
Description:
Bug 36076: paycollect.tt add permission checks for manual credit and invoice
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2024-03-03 22:30:19 UTC
Size:
2.75 KB
patch
obsolete
>From 56809e39ce26871672ecf5dfafd19a258160a1f8 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 13 Feb 2024 10:49:17 +0100 >Subject: [PATCH] Bug 36076: paycollect.tt add permission checks for manual > credit and invoice > >In members/pay.tt one can see permission checks for manual credit and invoice : >CAN_user_updatecharges_manual_invoice >CAN_user_updatecharges_manual_credit > >This is missing from members/paycollect.tt. >HTML is also missing classes manualcredit and manualinvoice. > >Test plan : >1) Create a user with permissions to manage accounting > (remaining_permissions under updatecharges) but without > manual_invoice and manual_credit >2) Go to a patron account with an invoice >3) Click on "Make a payment", you dont see tabs manual credit/invoice >4) Click on "Pay" in "Actions" column >=> Without patch you see tabs manual credit/invoice >=> With patch you do not see them > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > .../prog/en/modules/members/paycollect.tt | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt >index 0fa0259b2e..2f70b35ebb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt >@@ -105,12 +105,16 @@ > <li role="presentation" class="makepayment active"> > <a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% patron.borrowernumber | uri %]" role="tab">Make a payment</a> > </li> >- <li role="presentation"> >- <a href="/cgi-bin/koha/members/maninvoice.pl?borrowernumber=[% patron.borrowernumber | uri %]" role="tab">Create manual invoice</a> >- </li> >- <li role="presentation"> >- <a href="/cgi-bin/koha/members/mancredit.pl?borrowernumber=[% patron.borrowernumber | uri %]" role="tab">Create manual credit</a> >- </li> >+ [% IF CAN_user_updatecharges_manual_invoice %] >+ <li role="presentation" class="manualinvoice"> >+ <a href="/cgi-bin/koha/members/maninvoice.pl?borrowernumber=[% patron.borrowernumber | uri %]" role="tab">Create manual invoice</a> >+ </li> >+ [% END %] >+ [% IF CAN_user_updatecharges_manual_credit %] >+ <li role="presentation" class="manualcredit"> >+ <a href="/cgi-bin/koha/members/mancredit.pl?borrowernumber=[% patron.borrowernumber | uri %]" role="tab">Create manual credit</a> >+ </li> >+ [% END %] > </ul> <!-- /.nav.nav-tabs --> > <div class="tab-content"> > <div role="tabpanel" class="tab-pane active"> >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36076
:
162088
|
162252
| 162707