From 6953d252b23daec0e1f13a79c2c0f9adbbc6c77b Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 4 Dec 2023 14:38:48 +0000 Subject: [PATCH] Bug 33544: Link title in details to biblio This patch removes the biblio id column and instead adds the biblio link to the title field in the request details column when appropriate. --- admin/columns_settings.yml | 2 -- .../prog/en/includes/ill-list-table.inc | 1 - koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 14 +++----------- 3 files changed, 3 insertions(+), 14 deletions(-) diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml index 0ba7ab141a1..2854e362ad9 100644 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@ -905,8 +905,6 @@ modules: columnname: orderid - columnname: patron - - - columnname: biblio_id - columnname: library_branchname - diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc index 1c5ec6e8b1d..cf8b915b0c2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc @@ -13,7 +13,6 @@ Request type Order ID Patron - Bibliographic record ID Library Status Placed on diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js index 89d5b9c72c3..5d920cb2359 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js +++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js @@ -235,7 +235,9 @@ $(document).ready(function() { if ( display_extended_attribute(row, 'article_title') !== "" ) { display += ' Article: ' + display_extended_attribute(row, 'article_title') + ''; } - if ( display_extended_attribute(row, 'title') !== "" ) { + if ( row.biblio_id !== null ) { + display += ' Title: ' + $biblio_to_html(row.biblio, { link: 1 }) + ''; + } else if ( display_extended_attribute(row, 'title') !== "" ) { display += ' Title: ' + display_extended_attribute(row, 'title') + ''; } if ( display_extended_attribute(row, 'author') !== "" ) { @@ -274,16 +276,6 @@ $(document).ready(function() { "data": "patron.firstname:patron.surname:patron.cardnumber", "render": function(data, type, row, meta) { return (row.patron) ? $patron_to_html( row.patron, { display_cardnumber: true, url: true } ) : ''; } }, - { - "data": "biblio_id", - "orderable": true, - "render": function(data, type, row, meta) { - if ( data === null ) { - return ""; - } - return $biblio_to_html(row.biblio, { biblio_id_only: 1, link: 1 }); - } - }, { "data": "library.name", "orderable": true, -- 2.44.0