Bugzilla – Attachment 163047 Details for
Bug 32671
basic_workflow.t is failing on slow servers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32671: Prevent selenium/basic_workflow.t to fail if run on slow servers
Bug-32671-Prevent-seleniumbasicworkflowt-to-fail-i.patch (text/plain), 2.74 KB, created by
Jonathan Druart
on 2024-03-11 15:48:57 UTC
(
hide
)
Description:
Bug 32671: Prevent selenium/basic_workflow.t to fail if run on slow servers
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-03-11 15:48:57 UTC
Size:
2.74 KB
patch
obsolete
>From 318367fc92b78734e5906a99887ba06b292f52b7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 11 Mar 2024 16:41:12 +0100 >Subject: [PATCH] Bug 32671: Prevent selenium/basic_workflow.t to fail if run > on slow servers >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >When submitting the form to create a new patron we are doing a POST >memberentry.pl that is redirecting to moremember.pl > >The selenium test is expecting for the end of the request to test the >page's title against "Patron details for ". > >But it's only waiting for the POST response (302), not the GET >moremember that will display the patron's details. > >You can simulate a slow server using cpulimit: `cpulimit -b -p $PID -l 1` >replacing $PID with the pid of the starman process. > >Note that other tests are failing using 1%, but... baby steps. > >The current failre: > # Failed test at t/db_dependent/selenium/basic_workflow.t line 122 > Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 125 > # 'Add patron (test cat description) ⺠Patrons ⺠Koha' > # doesn't match '(?^u:Patron details for test_patron_surname)' > >The next one (NOT fixed by this patch): > > # Failed test at t/db_dependent/selenium/basic_workflow.t line 256. > # ' > # > # Checkouts (0)# # '# doesn't match '(?^u:Checkouts \(1\))' > t/db_dependent/selenium/basic_workflow.t .. 14/22 # Failed test at t/db_dependent/selenium/basic_workflow.t line 256. > # ' > # > # Checkouts (1) > # > # ' > # doesn't match '(?^u:Checkouts \(2\))' > t/db_dependent/selenium/basic_workflow.t .. 16/22 # Failed test at t/db_dependent/selenium/basic_workflow.t line 256. > # ' > # > # Checkouts (2) > # > # ' > # doesn't match '(?^u:Checkouts \(3\))' >--- > t/db_dependent/selenium/basic_workflow.t | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t >index 03c9f13c9d6..d8ee38c4778 100755 >--- a/t/db_dependent/selenium/basic_workflow.t >+++ b/t/db_dependent/selenium/basic_workflow.t >@@ -119,6 +119,8 @@ SKIP: { > like( $driver->get_title(), qr(Add .*$sample_data->{category}{description}), ); > $s->fill_form( $sample_data->{patron} ); > $driver->find_element('//button[@id="saverecord"]')->click; >+ my $borrowernumber = Koha::Patrons->_resultset->get_column('borrowernumber')->max; >+ $driver->get($base_url.'/members/moremember.pl?borrowernumber='.$borrowernumber); > like( $driver->get_title(), qr(Patron details for $sample_data->{patron}{surname}), ); > > ####$driver->get($base_url.'/members/members-home.pl'); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32671
: 163047