Bugzilla – Attachment 163121 Details for
Bug 36302
Patron search from search bar broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36302: Revert back to POST
Bug-36302-Revert-back-to-POST.patch (text/plain), 2.09 KB, created by
Lucas Gass
on 2024-03-13 21:29:39 UTC
(
hide
)
Description:
Bug 36302: Revert back to POST
Filename:
MIME Type:
Creator:
Lucas Gass
Created:
2024-03-13 21:29:39 UTC
Size:
2.09 KB
patch
obsolete
>From 51309c169dc33d6af36c2539c5cac8c2a601e799 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Wed, 13 Mar 2024 15:41:25 +0000 >Subject: [PATCH] Bug 36302: Revert back to POST > >Pass the csrf token and 'cud-noop' > >After having discussed with Joubu and multiple failed attempts at fixing the issue AND restoring previous behavior, this is the fix we agreed on. > >This will change URL but not fiddle with browser history. >Works the same (and as expected) in both Chrome and Firefox > >Test plan, ktd: >1) Search henry on the top search bar, notice 1 result is auto suggested >2) Ignore the auto-complete, press 'Enter' instead >3) Notice no results are returned. >4) Apply patch. Repeat. >5) Notice you get redirected to the single result of henry >6) Press the browser 'back' button and notice it works as expected (both Chrome+Firefox) >7) Visit patrons home directly: >http://localhost:8081/cgi-bin/koha/members/members-home.pl >8) Notice no search is performed > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/includes/member-search-box.inc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/member-search-box.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/member-search-box.inc >index a4ea643d90..a9bf4b8760 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/member-search-box.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/member-search-box.inc >@@ -10,8 +10,10 @@ > [% ELSE %] > <div id="patron_search" role="tabpanel" class="tab-pane"> > [% END %] >- <form action="/cgi-bin/koha/members/member.pl" method="get"> >+ <form action="/cgi-bin/koha/members/member.pl" method="post"> >+ [% INCLUDE 'csrf-token.inc' %] > <input type="hidden" name="quicksearch" value="1" /> >+ <input type="hidden" name="op" value="cud-noop" /> > > <div class="form-title"> > <label class="control-label" for="searchmember"><span class="control-text">Search patrons</span> <i class="fa fa-fw fa-id-card" aria-hidden="true"></i></label> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36302
:
163096
|
163099
|
163105
|
163106
|
163108
|
163109
|
163113
|
163121
|
163122
|
163207
|
163226
|
163487
|
163917
|
163918
|
163974
|
164002
|
164003
|
164004
|
164005