From 1da7b0a433da367f5d760788edebfa3f52330c3a Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Mon, 15 Jan 2024 16:45:03 +0000
Subject: [PATCH] Bug 35813: Add success feedback after placing/editing
 bookings

This patch restores the lost behaviour that a successful add/edit of a
booking via the 'Place booking' modal should notify the end user that
the submission was sucessful.

Test plan
1) Set an item as bookable to expose the 'Place booking' button
2) Place a new booking from the following pages and confirm that you
   now recieve feedback.
   * Catalog > Title > Details
   * Catalog > Title > MARC details
   * Catalog > Title > ISBD details
   * Catalog > Title > Item details
   * Catalog > Title > Bookings
3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm
   you now recieve feedback.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt | 1 +
 .../prog/en/modules/catalogue/ISBDdetail.tt              | 1 +
 .../prog/en/modules/catalogue/MARCdetail.tt              | 1 +
 .../intranet-tmpl/prog/en/modules/catalogue/detail.tt    | 1 +
 .../prog/en/modules/catalogue/moredetail.tt              | 4 ++--
 koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js  | 9 +++++++++
 6 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
index c525f605c96..c5ef30b3e5f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
@@ -38,6 +38,7 @@
         <div class="col-sm-10 col-sm-push-2">
             <main>
                 <div class="row">
+                    <div id="transient_result"></div>
                     [% INCLUDE 'cat-toolbar.inc' %]
                     <h1>Bookings for [% INCLUDE 'biblio-title-head.inc' %]</h1>
                     <div class="page-section" id="bookings-timeline"></div>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
index 9ad5d244ed1..dfc82cbb253 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
@@ -48,6 +48,7 @@
         <div class="col-sm-10 col-sm-push-2">
             <main>
                 [% INCLUDE 'messages.inc' %]
+                <div id="transient_result"></div>
             [% INCLUDE 'cat-toolbar.inc' %]
                 <h1>
                     [% IF ( unknownbiblionumber ) %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
index 75acf77a0b0..6ed54945248 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
@@ -55,6 +55,7 @@
   <div class="dialog message">The record you requested does not exist ([% biblionumber | html %]).</div>
 [% ELSE %]
 
+<div id="transient_result"></div>
 [% INCLUDE 'cat-toolbar.inc' %]
 
 [% UNLESS ( popup ) %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index 501177ac76a..9038da31976 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -92,6 +92,7 @@
 [% CoceHost        = Koha.Preference('CoceHost') %]
 [% SyndeticsCovers = Koha.Preference('SyndeticsEnabled') && Koha.Preference('SyndeticsCoverImages') %]
 
+<div id="transient_result"></div>
 [% INCLUDE 'cat-toolbar.inc' %]
     [% IF ( ocoins ) %]
         <!-- COinS / OpenURL -->
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
index aabed1ca3b8..2e43b3c45f4 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
@@ -42,11 +42,11 @@
         <div class="col-sm-10 col-sm-push-2">
             <main>
                 [% INCLUDE 'messages.inc' %]
+                <div id="transient_result"></div>
+                [% INCLUDE 'cat-toolbar.inc' %]
 
                 <h1>Item details for [% INCLUDE 'biblio-title-head.inc' %]</h1>
 
-                [% INCLUDE 'cat-toolbar.inc' %]
-
                 <div id="catalogue_detail_biblio">
                     <div class="page-section clearfix">
                         <h2>[% title | html %]</h2>
diff --git a/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js b/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js
index 363dedf5926..175318d5775 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js
@@ -614,6 +614,9 @@ $("#placeBookingForm").on("submit", function (e) {
                 parseInt($(".bookings_count").html(), 10) + 1
             );
 
+            // Set feedback
+            $('#transient_result').replaceWith('<div id="transient_result" class="dialog success">'+_("Booking successfully placed")+'</div>');
+
             // Close modal
             $("#placeBookingModal").modal("hide");
         });
@@ -674,6 +677,12 @@ $("#placeBookingForm").on("submit", function (e) {
                 timeline.focus(data.booking_id);
             }
 
+<<<<<<< HEAD
+=======
+            // Set feedback
+            $('#transient_result').replaceWith('<div id="transient_result" class="dialog success">'+_("Booking successfully updated")+'</div>');
+
+>>>>>>> 9195757e2f1 (Bug 35813: Add success feedback after placing/editing bookings)
             // Close modal
             $("#placeBookingModal").modal("hide");
         });
-- 
2.44.0