Bugzilla – Attachment 163652 Details for
Bug 36388
Mouse operation does not work in draggable fields in authority editor (with Firefox)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36388: Mouse operation does not work in draggable fields in authority editor
Bug-36388-Mouse-operation-does-not-work-in-draggab.patch (text/plain), 3.73 KB, created by
Lucas Gass (lukeg)
on 2024-03-21 19:51:17 UTC
(
hide
)
Description:
Bug 36388: Mouse operation does not work in draggable fields in authority editor
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-03-21 19:51:17 UTC
Size:
3.73 KB
patch
obsolete
>From e2a4868b1867ebaa0942dd78e940e3e975203b5f Mon Sep 17 00:00:00 2001 >From: Janusz Kaczmarek <januszop@gmail.com> >Date: Thu, 21 Mar 2024 16:20:24 +0100 >Subject: [PATCH] Bug 36388: Mouse operation does not work in draggable fields > in authority editor > >When using the authority editor in Firefox, it is not possible to set >the cursor or select text from the text field. > >This patch mimics the corrections made in bug 35425 for biblio editor. > >Test plan: >========== >1. Start editing an existing authority record and try to put the cursor > with the mouse in the middle of the content of any subfield or to > select text with the mouse. It should not be possilbe. >2. Apply the patch (reload plack etc.). >3. Repeat p. 1 - everything should work as expected. > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../en/modules/authorities/authorities.tt | 26 +++++++++++-------- > 1 file changed, 15 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >index 101187a51a..79787eb8d9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >@@ -48,17 +48,17 @@ > selectTab( "#tab0XX_panel" ); > } > >- $("#authoritytabs ul.sortable_field").each( (i, e) => { >- Sortable.create(e, { >- animation: 150 >- }); >- }); >- >- $("#authoritytabs ul.sortable_subfield").each( (i, e) => { >- Sortable.create(e, { >- animation: 150 >- }); >- }); >+ function initializeSortable(selector) { >+ $(selector).each((i, e) => { >+ Sortable.create(e, { >+ handle: '.handle', >+ direction: 'vertical', >+ animation: 150, >+ }); >+ }); >+ } >+ initializeSortable("#authoritytabs ul.sortable_field"); >+ initializeSortable("#authoritytabs ul.sortable_subfield"); > > Sticky = $("#toolbar"); > Sticky.hcSticky({ >@@ -556,6 +556,9 @@ > > <div class="tag_title" id="div_indicator_tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]"> > [% UNLESS hide_marc %] >+ [% IF ( innerloo.repeatable ) %] >+ <span class="handle"></span> >+ [% END %] > [% IF advancedMARCEditor %] > <a href="#" tabindex="1" class="tagnum" title="[% innerloo.tag_lib | html %] - Click to expand this tag" data-field_id="tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'">[% innerloo.tag | html %]</a> > [% ELSE %] >@@ -638,6 +641,7 @@ > > [% UNLESS hide_marc %] > <div class="subfieldcode"> >+ <span class="handle"></span> > <input type="text" > title="[% subfield_loo.marc_lib | $raw %]" > style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]border:0;" >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36388
:
163633
|
163652
|
165825
|
165851
|
165852
|
166105
|
166478