From e1e6746d8da35330d0681359ebc9ace0190ddb8a Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Thu, 21 Mar 2024 10:15:23 +0100
Subject: [PATCH] Bug 35138: Adjust existing data

We want the label from the DB displayed on the UI so we are adjusting
the yaml and the DB.

Sponsored-by: The Research University in the Helmholtz Association (KIT)
---
 .../searchengine/elasticsearch/mappings.yaml  | 20 +++++------
 .../data/mysql/atomicupdate/bug_35138.pl      | 33 +++++++++++++++++++
 2 files changed, 43 insertions(+), 10 deletions(-)
 create mode 100755 installer/data/mysql/atomicupdate/bug_35138.pl

diff --git a/admin/searchengine/elasticsearch/mappings.yaml b/admin/searchengine/elasticsearch/mappings.yaml
index f9f9a042c5b..5b1e0aae735 100644
--- a/admin/searchengine/elasticsearch/mappings.yaml
+++ b/admin/searchengine/elasticsearch/mappings.yaml
@@ -986,7 +986,7 @@ biblios:
     type: ''
   author:
     facet_order: 1
-    label: author
+    label: Authors
     mandatory: ~
     mappings:
     - facet: 1
@@ -1281,7 +1281,7 @@ biblios:
     type: ''
   ccode:
     facet_order: 7
-    label: collection-code
+    label: Collections
     mandatory: ~
     mappings:
     - facet: 1
@@ -1857,7 +1857,7 @@ biblios:
     type: ''
   holdingbranch:
     facet_order: 8
-    label: holdinglibrary
+    label: Holding libraries
     mandatory: ~
     mappings:
     - facet: 1
@@ -1875,7 +1875,7 @@ biblios:
     type: string
   homebranch:
     facet_order: 9
-    label: homelibrary
+    label: Home libraries
     mandatory: ~
     mappings:
     - facet: 1
@@ -2133,7 +2133,7 @@ biblios:
     type: ''
   itype:
     facet_order: 2
-    label: itype
+    label: Item types
     mandatory: ~
     mappings:
     - facet: 1
@@ -2485,7 +2485,7 @@ biblios:
     type: ''
   ln:
     facet_order: 10
-    label: ln
+    label: Languages
     mandatory: ~
     mappings:
     - facet: 1
@@ -2566,7 +2566,7 @@ biblios:
     type: number
   location:
     facet_order: 3
-    label: location
+    label: Location
     mandatory: ~
     mappings:
     - facet: 1
@@ -3352,7 +3352,7 @@ biblios:
     type: ''
   su-geo:
     facet_order: 4
-    label: su-geo
+    label: Places
     mandatory: ~
     mappings:
     - facet: 1
@@ -3370,7 +3370,7 @@ biblios:
     type: string
   subject:
     facet_order: 6
-    label: subject
+    label: Topics
     mandatory: ~
     mappings:
     - facet: 1
@@ -4132,7 +4132,7 @@ biblios:
     type: ''
   title-series:
     facet_order: 5
-    label: title-series
+    label: Series
     mandatory: ~
     mappings:
     - facet: 1
diff --git a/installer/data/mysql/atomicupdate/bug_35138.pl b/installer/data/mysql/atomicupdate/bug_35138.pl
new file mode 100755
index 00000000000..14b48246faa
--- /dev/null
+++ b/installer/data/mysql/atomicupdate/bug_35138.pl
@@ -0,0 +1,33 @@
+use Modern::Perl;
+
+return {
+    bug_number  => "35138",
+    description => "Make the elastic facets editable",
+    up          => sub {
+        my ($args) = @_;
+        my ( $dbh, $out ) = @$args{qw(dbh out)};
+
+        my $facets = {
+            author         => 'Authors',
+            itype          => 'Item types',
+            location       => 'Location',
+            'su-geo'       => 'Places',
+            'title-series' => 'Series',
+            subject        => 'Topics',
+            ln             => 'Languages',
+        };
+        # Do not update the label if different from the original one
+        my $sth = $dbh->prepare(q{
+            UPDATE search_field
+            SET label = ?
+            WHERE name = ? AND label = ?
+        });
+        while ( my ( $name, $label ) = each %$facets ) {
+            $sth->execute( $label, $name, $name );
+        }
+
+        $sth->execute( 'Collections', 'ccode', 'collection-code');
+        $sth->execute( 'Holding libraries', 'holdingbranch', 'holdinglibrary');
+        $sth->execute( 'Home libraries', 'homebranch', 'homelibrary');
+    },
+};
-- 
2.34.1