From ac43fa77ed4f328005acc2155dcb756b432c6755 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 21 Mar 2024 14:16:23 +0100 Subject: [PATCH] Bug 36394: Fix footers behaviour on the ES mapping page In the footers of the tables of the search fields and mappings, the options selected are not consistent. Additionally they are not reset correctly when a new line is added. Test plan: 0. Do not apply to recreate the problem 1. Go to the ES mapping page 2. Click tab "Bibliographic records" 3. At the bottom, notice the Yes/No dropdown lists => They are inconsistent, sometimes 'Yes', sometimes 'No' 4. Click Add => Values are kept 5. Apply this patch 6. Repeat 1, 2, 3 => No (first option) is always selected 7. Click Add after you modified some values => "No" is selected Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Christopher Brannon --- .../searchengine/elasticsearch/mappings.tt | 36 +++++-------------- .../prog/js/elasticsearch-mappings.js | 2 +- 2 files changed, 9 insertions(+), 29 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt index 164bf6f7c4..984e6c8518 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt @@ -404,46 +404,26 @@ a.add, a.delete { diff --git a/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js b/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js index 696d8d5cf7..b40fec0f45 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js +++ b/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js @@ -2,7 +2,7 @@ function clean_line(line) { $(line).find('input[type="text"]').val(""); - $(line).find('select').find('option:first').attr("selected", "selected"); + $(line).find('select').find('option:first').prop("selected", true); } function clone_line(line) { -- 2.30.2