From ae3b952fbb216f7f15e8439974c5cb0c8b81a78b Mon Sep 17 00:00:00 2001
From: Hammat Wele <hammat.wele@inlibro.com>
Date: Mon, 25 Mar 2024 16:16:55 +0000
Subject: [PATCH] Bug 31736: Editing 'All' to 'All libraries'

This patch edit the term 'All' to 'All libraries/branches', beacause All can have different genders depending on the used language ( in french All could mean 'tous for 'male-gendered' things and 'toutes' for 'female-gendered' things).

1. Apply patch

2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All libraries/branches'
   --> No spelling errors in 'All' libraries

   - Acquisitions > Invoices (Library filter on the left)
   - Circulation > Holds queue (Library filter)
   - Reports > Cash register (Transaction library filter)
   - Reports > Items lost (Library filter)
   - Serials > Check expiration (Library filter)
   - Serials > Search settings icon in the search bar > Advanced search (Library filter)
   - Acquisitions > Add to basket > From a subscription (Library filter on the left)
   - Installer > Onboarding > New circulation rule (Library)
---
 koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc  | 2 +-
 .../intranet-tmpl/prog/en/includes/subscriptions-search.inc     | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt       | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 2 +-
 .../intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt | 2 +-
 .../prog/en/modules/reports/cash_register_stats.tt              | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt    | 2 +-
 .../intranet-tmpl/prog/en/modules/serials/checkexpiration.tt    | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc
index ec34b6f073..63f316945a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc
@@ -37,7 +37,7 @@
                 <li class="local">
                     <label for="branch">Library:</label>
                     <select id="branch" name="branch_filter">
-                        <option value="">All</option>
+                        <option value="">All libraries/branches</option>
                         [%# FIXME Should not we filter the libraries? %]
                         [% PROCESS options_for_libraries libraries => Branches.all( selected => branch_filter, unfiltered => 1 ) %]
                     </select>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc
index 5e1275d249..fb68cc4456 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc
@@ -30,7 +30,7 @@
               <li>
                 <label for="branch">Library:</label>
                 <select id="branch" name="branch_filter">
-                  <option value="">All</option>
+                  <option value="">All libraries/branches</option>
                   [%# FIXME Should not we filter the libraries? %]
                   [% PROCESS options_for_libraries libraries => Branches.all( selected => branch_filter, unfiltered => 1 ) %]
                 </select>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
index f189ba2b5b..4f880e885f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
@@ -380,7 +380,7 @@
                             <li>
                                 <label for="branch">Library:</label>
                                 <select id="branch" name="branch">
-                                    <option value="">All</option>
+                                    <option value="">All libraries/branches</option>
                                     [%# FIXME Should not we filter the libraries %]
                                     [% PROCESS options_for_libraries libraries => Branches.all( selected => branch, unfiltered => 1 ) %]
                                 </select>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
index 49f2342125..a9ba315046 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
@@ -261,7 +261,7 @@
                     <label for="branchlimit">Library: </label>
                     <select name="branchlimit" id="branchlimit">
                         [% IF CAN_user_superlibrarian || !Koha.Preference('IndependentBranches') %]
-                            <option value="">All</option>
+                            <option value="">All libraries/branches</option>
                         [% END %]
                         [% PROCESS options_for_libraries libraries => Branches.all( selected => branchlimit, only_from_group => 1 ) %]
                     </select>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
index 3ae2065812..d86c408615 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
@@ -65,7 +65,7 @@
                                     <label for="branchname" class="required"> Library branch</label>
                                     <select name="branch" id="branchname" required="required">
                                         <option value=""> Choose</option>
-                                        <option value="*" selected="selected">All</option>
+                                        <option value="*" selected="selected">All libraries/branches</option>
                                         [% FOREACH library IN libraries %]
                                             <option value="[% library.branchcode | html %]"> [% library.branchname | html %]</option>
                                         [% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
index 327c38b184..fa9cb36000 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
@@ -120,7 +120,7 @@
                 <li>
                     <label>Transaction library</label>
                     <select name="branch" id="branch">
-                        <option value="ALL">All</option>
+                        <option value="ALL">All libraries/branches</option>
                         [% FOREACH branchloo IN branchloop %]
                             [% IF ( branchloo.selected ) %]
                             <option value="[% branchloo.branchcode | html %]" selected="selected">[% branchloo.branchname | html %]</option>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
index bf210c08a6..cf8d2de5d3 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
@@ -148,7 +148,7 @@
 
 	<li><label for="barcodefilter">Barcode: </label><input type="text" name="barcodefilter" id="barcodefilter" size="6" /></li>
 	<li><label for="branchfilter">Library: </label><select name="branchfilter" id="branchfilter">
-                <option value="">All</option>
+                <option value="">All libraries/branches</option>
                 [% PROCESS options_for_libraries libraries => Branches.all() %]
             </select></li>
     <li><label for="itemtypesfilter">Item type: </label><select name="itemtypesfilter" id="itemtypesfilter">
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
index 66c066fe6e..bf40a7698d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
@@ -45,7 +45,7 @@
         [% IF can_change_library %]
         <li><label for="branch">Library:</label>
         <select id="branch" name="branch">
-            <option value="">All</option>
+            <option value="">All libraries/branches</option>
             [% PROCESS options_for_libraries libraries => Branches.all( selected => branch ) %]
         </select>
         </li>
-- 
2.34.1