From 5268a45dc1eb7a7786c750ad248a027b3351c382 Mon Sep 17 00:00:00 2001 From: Fridolin Somers <fridolin.somers@biblibre.com> Date: Mon, 25 Mar 2024 15:53:10 +0100 Subject: [PATCH] Bug 35599: Fix Pronouns and HidePersonalPatronDetailOnCirculation Bug 10950 adds a pronouns text field to the patron record. Currently it is hidden by system preference 'HidePersonalPatronDetailOnCirculation'. This patch moves pronouns outside this system preference influence. Test plan: 1) Add pronouns to a patron 2) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Don't hide" 3) Check you see pronouns in circulation page /cgi-bin/koha/circ/circulation.pl?borrowernumber=X 4) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Hide" 5) Refresh circulation page => Without patch pronouns are hidden => With patch pronouns are displayed Signed-off-by: Hebah <hebah@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> --- koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc index bb12e1bef3..6facc63971 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ -57,10 +57,12 @@ [% END %] <ul class="patronbriefinfo"> + + [% IF patron.pronouns %] + <li class="patronpronouns">([% patron.pronouns | html %])</li> + [% END %] + [% IF !(Koha.Preference('HidePersonalPatronDetailOnCirculation')) %] - [% IF patron.pronouns %] - <li class="patronpronouns">([% patron.pronouns | html %])</li> - [% END %] [% PROCESS 'display-address-style' %] -- 2.30.2