Bugzilla – Attachment 164114 Details for
Bug 36159
Patron imports record a change for non-text columns that are not in the import file
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36159: (QA follow-up): Simplify code to supress warnings
Bug-36159-QA-follow-up-Simplify-code-to-supress-wa.patch (text/plain), 1.33 KB, created by
Marcel de Rooy
on 2024-03-29 08:46:54 UTC
(
hide
)
Description:
Bug 36159: (QA follow-up): Simplify code to supress warnings
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-03-29 08:46:54 UTC
Size:
1.33 KB
patch
obsolete
>From 568765b34b74385716274d296670b1fa0eb7e7bc Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 28 Mar 2024 06:20:29 -0400 >Subject: [PATCH] Bug 36159: (QA follow-up): Simplify code to supress warnings >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Patron.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index 265bcd78be..3e9211be47 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -385,8 +385,10 @@ sub store { > my @skip_fields = (qw/lastseen updated_on/); > for my $key ( keys %{$from_storage} ) { > next if any { /$key/ } @skip_fields; >- if ( ( $from_storage->{$key} || $from_object->{$key} ) >- && ( $from_storage->{$key} ne $from_object->{$key} ) ) >+ my $storage_value = $from_storage->{$key} // q{}; >+ my $object_value = $from_object->{$key} // q{}; >+ if ( ( $storage_value || $object_value ) >+ && ( $storage_value ne $object_value ) ) > { > $info->{$key} = { > before => $from_storage->{$key}, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36159
:
162392
|
162669
|
162672
|
162689
|
164038
|
164039
|
164040
|
164113
| 164114 |
164115
|
164124