From 32d06e228607086be5c259ea1f53a34e846a30fe Mon Sep 17 00:00:00 2001 From: Hammat Wele Date: Fri, 29 Mar 2024 21:29:23 +0000 Subject: [PATCH] Bug 33039: Incorrect date value stored when 'Published on' or 'Expected on' are empty MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When we edit a serial and we leave the date fields ('Published on' or 'Expected on') empty incorrect date are saved in the database 0000-00-00 instade of current date and we get Error 500 to reproduce 1. Connect to staff interface 2. Go to Serials and create a new subscription 3. Click on Serial collection in the left menu (and note the Subscription numnber) 4. Select a serial to edit and Click on «Edit serials» 5. In the Serial edition form, delete «Published on > and « Expected on » dates and save ----> Error 500 page is displayed 6. Check the value of «Published on > and « Expected on » dates in the database select planneddate,publisheddate from serial where subscriptionid=; ------> planneddate publisheddate have «0000-00-00» value 7. Apply the patch 8. repeat step 2, 3, 4, 5, 6 -----> Error 500 page is no more displayed -----> «Published on » and « Expected on » field have today date https://bugs.koha-community.org/show_bug.cgi?id=36466 --- serials/serials-edit.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/serials/serials-edit.pl b/serials/serials-edit.pl index 6acefa5918..d1388f0c64 100755 --- a/serials/serials-edit.pl +++ b/serials/serials-edit.pl @@ -209,10 +209,10 @@ if ( $op and $op eq 'cud-serialchangestatus' ) { my ($plan_date, $pub_date); if (defined $planneddates[$i] && $planneddates[$i] ne 'XXX') { - $plan_date = $planneddates[$i]; + $plan_date = $planneddates[$i] || $today; } if (defined $publisheddates[$i] && $publisheddates[$i] ne 'XXX') { - $pub_date = $publisheddates[$i]; + $pub_date = $publisheddates[$i] || $today; } if ( $serialids[$i] && $serialids[$i] eq 'NEW' ) { -- 2.34.1