Bugzilla – Attachment 164249 Details for
Bug 36400
Centralize {js,ts,vue} formatting config in .prettierrc.js
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36400 (follow-up): remove option editorconfig from .prettierrc.js
Bug-36400-follow-up-remove-option-editorconfig-fro.patch (text/plain), 1.02 KB, created by
Jonathan Druart
on 2024-04-02 09:56:09 UTC
(
hide
)
Description:
Bug 36400 (follow-up): remove option editorconfig from .prettierrc.js
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-04-02 09:56:09 UTC
Size:
1.02 KB
patch
obsolete
>From aa60d920040415a50568cf270e7ab4a810267236 Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Mon, 25 Mar 2024 14:55:13 +0100 >Subject: [PATCH] Bug 36400 (follow-up): remove option editorconfig from > .prettierrc.js > >- The option doesn't seem do what it's intended for: > - The debug logs still show options from the .editorconfig (which is actually what we want in this case). >- The option causes unwanted warnings when using the cli. >- In summary: we have to keep in mind that the rules are now hierarchical: > 1. .editorconfig > 2. .prettierrc.js > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .prettierrc.js | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/.prettierrc.js b/.prettierrc.js >index 62b9288b563..2e9ca72393e 100644 >--- a/.prettierrc.js >+++ b/.prettierrc.js >@@ -1,6 +1,5 @@ > module.exports = { > arrowParens: "avoid", >- editorconfig: "false", > trailingComma: "es5", > overrides: [ > { >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36400
:
163695
|
163710
|
163799
|
163818
|
163825
|
164248
| 164249