From eb7477e012e5c31a441ca2ac026f21c4e498d678 Mon Sep 17 00:00:00 2001 From: Matthias Le Gac Date: Tue, 2 Apr 2024 16:26:17 -0400 Subject: [PATCH] Bug 9762: Change how to pass the param issueconfirmed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To test: --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") --- C4/Circulation.pm | 16 +--------------- circ/circulation.pl | 1 + 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index a974a45ac1..e9f1341d82 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -318,21 +318,6 @@ A recall for this item was found, and the item needs to be transferred to the re =cut -my $query = CGI->new; - -my $stickyduedate = $query->param('stickyduedate'); -my $duedatespec = $query->param('duedatespec'); -my $restoreduedatespec = $query->param('restoreduedatespec') || $duedatespec; -if ( $restoreduedatespec && $restoreduedatespec eq "highholds_empty" ) { - undef $restoreduedatespec; -} -my $issueconfirmed = $query->param('issueconfirmed'); -my $cancelreserve = $query->param('cancelreserve'); -my $cancel_recall = $query->param('cancel_recall'); -my $recall_id = $query->param('recall_id'); -my $debt_confirmed = $query->param('debt_confirmed') || 0; # Don't show the debt error dialog twice -my $charges = $query->param('charges') || q{}; - sub transferbook { my $params = shift; my $tbr = $params->{to_branch}; @@ -795,6 +780,7 @@ sub CanBookBeIssued { my $onsite_checkout = $params->{onsite_checkout} || 0; my $override_high_holds = $params->{override_high_holds} || 0; + my $issueconfirmed = $params->{issueconfirmed} || 0; my $item_object = $params->{item} // Koha::Items->find( { barcode => $barcode } ); diff --git a/circ/circulation.pl b/circ/circulation.pl index 4f0c5b8f80..0905238bba 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -337,6 +337,7 @@ if (@$barcodes && $op eq 'cud-checkout') { { onsite_checkout => $onsite_checkout, override_high_holds => $override_high_holds || $override_high_holds_tmp || 0, + issueconfirmed => $issueconfirmed, } ); } catch { -- 2.34.1