@@ -, +, @@
transfers
---
Koha/Item/Transfer.pm | 15 +++++++++++++++
api/v1/swagger/paths/biblios.yaml | 1 +
.../prog/en/modules/catalogue/detail.tt | 6 +++---
3 files changed, 19 insertions(+), 3 deletions(-)
--- a/Koha/Item/Transfer.pm
+++ a/Koha/Item/Transfer.pm
@@ -176,6 +176,21 @@ sub cancel {
return $self;
}
+
+=head3 strings_map
+
+Returns a map of column name to string representations including the string.
+
+=cut
+
+sub strings_map {
+ my ($self) = @_;
+ return {
+ from_library => { str => $self->from_library->branchname, type => 'library' },
+ to_library => { str => $self->to_library->branchname, type => 'library' },
+ };
+}
+
=head3 type
=cut
--- a/api/v1/swagger/paths/biblios.yaml
+++ a/api/v1/swagger/paths/biblios.yaml
@@ -426,6 +426,7 @@
- checkout
- checkout.patron
- transfer
+ - transfer+strings
- first_hold
- first_hold.patron
- recall
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -2173,7 +2173,7 @@
[%# In case or SeparateHoldings we may need to display the number of biblios in each tab %]
[%# Do we need separate/new endpoints or do we hack the somewhere client-side? %]
let item_table_url = "/api/v1/biblios/[% biblio.biblionumber | uri %]/items?";
- let embed = ["+strings,checkout,checkout.patron,transfer,first_hold,first_hold.patron,item_type"];
+ let embed = ["+strings,checkout,checkout.patron,transfer,transfer+strings,first_hold,first_hold.patron,item_type"];
[% IF Koha.Preference('LocalCoverImages') %]
embed.push('cover_image_ids');
[% END %]
@@ -2397,9 +2397,9 @@
nodes += ""
} else if ( row.transfer ) {
if ( row.transfer.datesent ) {
- nodes += '%s'.format(_("In transit from %s to %s since %s").format(escape_str(row.transfer.frombranch), escape_str(row.transfer.tobranch), $date(row.transfer.datesent))); [%# FIXME display library names, not codes, do we use _strings here? %]
+ nodes += '%s'.format(_("In transit from %s to %s since %s").format(escape_str(row.transfer._strings.from_library.str), escape_str(row.transfer._strings.to_library.str), $date(row.transfer.datesent)));
} else {
- nodes += '%s'.format(_("Transit pending from %s to %s since %s").format(escape_str(row.transfer.frombranch), escape_str(row.transfer.tobranch), $date(row.transfer.daterequested))); [%# FIXME See above %]
+ nodes += '%s'.format(_("Transit pending from %s to %s since %s").format(escape_str(row.transfer._strings.from_library_.str), escape_str(row.transfer._strings.to_library.str), $date(row.transfer.daterequested)));
}
}
--