Bugzilla – Attachment 164351 Details for
Bug 33568
Use the REST API to display items on the biblio detail view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33568: (follow-up) Restore filters
Bug-33568-follow-up-Restore-filters.patch (text/plain), 5.82 KB, created by
Jonathan Druart
on 2024-04-03 07:40:35 UTC
(
hide
)
Description:
Bug 33568: (follow-up) Restore filters
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-04-03 07:40:35 UTC
Size:
5.82 KB
patch
obsolete
>From a57c44fb724a70ef0b1aeec81a02d23907a90c7e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 2 Jun 2023 11:15:32 +0200 >Subject: [PATCH] Bug 33568: (follow-up) Restore filters >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This is a bit ugly but fixes the problem raised in the previous commit, >as well as others > >for instance comment 18 >"* Click 'show filters', 'hide filters' and repeat X 2 - status column disappears?" > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> >--- > .../tables/items/catalogue_detail.inc | 67 ++++++++++++------- > 1 file changed, 41 insertions(+), 26 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >index 488227df2d0..94f8e91dc81 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >@@ -3,32 +3,7 @@ > [% USE AuthorisedValues %] > [% USE raw %] > >-[% BLOCK items_table %] >- <div class="[% tab | html %]_table_table_controls"> >- [% IF (StaffDetailItemSelection) %] >- >- <span class="show_hide_filters"> >- <a href="#" class="show_filters" data-tab="[% tab | html %]"><i class="fa fa-filter"></i> Show filters</a> >- <a href="#" class="hide_filters" data-tab="[% tab | html %]" style="display: none;"><i class="fa fa-filter"></i> Hide filters</a> >- </span> >- | <a href="#" class="SelectAll" data-tab="[% tab | html %]"><i class="fa fa-check"></i> Select all</a> >- | <a href="#" class="ClearAll" data-tab="[% tab | html %]"><i class="fa fa-times"></i> Clear all</a> >- <span class="itemselection_actions"> >- | Actions: >- [% IF CAN_user_tools_items_batchdel %] >- <a class="itemselection_action_delete"><i class="fa fa-trash-can"></i> Delete selected items</a> >- [% END %] >- [% IF CAN_user_tools_items_batchmod %] >- <a class="itemselection_action_modify"><i class="fa-solid fa-pencil"></i> Modify selected items</a> >- [% END %] >- [% IF CAN_user_editcatalogue_manage_item_groups && biblio.item_groups.count %] >- <a class="itemselection_action_item_group_set" href="#"><i class="fa fa-book"></i> Add/move to item group</a> >- <a class="itemselection_action_item_group_unset" href="#"><i class="fa fa-unlink"></i> Remove from item group</a> >- [% END %] >- </span> >- [% END %] >- </div> >- >+[% BLOCK build_table %] > <table class="items_table" id="[% tab | html %]_table"> > <thead> > [% IF (StaffDetailItemSelection) %]<th id="[% tab | html %]_checkbox" data-colname="[% tab | html %]_checkbox" class="NoSort"></th>[% END %] >@@ -65,6 +40,34 @@ > </tr> > </thead> > </table> >+[% END %] >+[% BLOCK items_table %] >+ <div class="[% tab | html %]_table_table_controls"> >+ [% IF (StaffDetailItemSelection) %] >+ >+ <span class="show_hide_filters"> >+ <a href="#" class="show_filters" data-tab="[% tab | html %]"><i class="fa fa-filter"></i> Show filters</a> >+ <a href="#" class="hide_filters" data-tab="[% tab | html %]" style="display: none;"><i class="fa fa-filter"></i> Hide filters</a> >+ </span> >+ | <a href="#" class="SelectAll" data-tab="[% tab | html %]"><i class="fa fa-check"></i> Select all</a> >+ | <a href="#" class="ClearAll" data-tab="[% tab | html %]"><i class="fa fa-times"></i> Clear all</a> >+ <span class="itemselection_actions"> >+ | Actions: >+ [% IF CAN_user_tools_items_batchdel %] >+ <a class="itemselection_action_delete"><i class="fa fa-trash-can"></i> Delete selected items</a> >+ [% END %] >+ [% IF CAN_user_tools_items_batchmod %] >+ <a class="itemselection_action_modify"><i class="fa-solid fa-pencil"></i> Modify selected items</a> >+ [% END %] >+ [% IF CAN_user_editcatalogue_manage_item_groups && biblio.item_groups.count %] >+ <a class="itemselection_action_item_group_set" href="#"><i class="fa fa-book"></i> Add/move to item group</a> >+ <a class="itemselection_action_item_group_unset" href="#"><i class="fa fa-unlink"></i> Remove from item group</a> >+ [% END %] >+ </span> >+ [% END %] >+ </div> >+ >+ [% PROCESS build_table tab => tab %] > [% END %][%# end of block items_table %] > > >@@ -211,8 +214,20 @@ > otherholdings: [% TablesSettings.GetTableSettings('catalogue', 'detail','otherholdings_table','json') | $raw %], > }; > >+ let table_nodes = { >+ holdings: '[% PROCESS 'build_table' tab="holdings" | collapse %]', >+ otherholdings: '[% PROCESS 'build_table' tab="otherholdings" | collapse %]', >+ }; > function build_items_table (tab_id, add_filters, dt_options) { > >+ if ( dt_options && dt_options.hasOwnProperty('destroy') ) { >+ let table_id = "#"+tab_id+"_table"; >+ if( $.fn.dataTable.isDataTable(table_id) ) { >+ $(table_id).DataTable().destroy(); >+ } >+ $(table_id).replaceWith(table_nodes[tab_id]); >+ dt_options['destroy'] = null; >+ } > let default_filters = {}; > [% IF Koha.Preference('SeparateHoldings') %] > [% SET SeparateHoldingsBranch = Koha.Preference('SeparateHoldingsBranch') || 'homebranch' %]; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33568
:
151339
|
153791
|
164308
|
164309
|
164310
|
164311
|
164312
|
164313
|
164314
|
164315
|
164316
|
164317
|
164318
|
164319
|
164320
|
164321
|
164322
|
164323
|
164324
|
164325
|
164326
|
164327
|
164328
|
164329
|
164330
|
164331
|
164332
|
164333
|
164334
|
164335
|
164336
|
164337
|
164338
|
164339
|
164340
|
164341
|
164342
|
164343
|
164344
|
164345
|
164346
|
164347
|
164348
|
164349
|
164350
|
164351
|
164352
|
164353
|
164354
|
164355
|
164356
|
164358
|
164359
|
164360
|
164361
|
164362
|
164363
|
164364
|
164365
|
164366
|
164367
|
164368
|
164369
|
164370
|
164371
|
164372
|
164373
|
164374
|
164472
|
164480
|
164482
|
164483
|
164485
|
164528