Bugzilla – Attachment 164452 Details for
Bug 23296
Auto Renewal Notice does not use Library specific notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23296: Set patron branchcode when preparing non-digest version
Bug-23296-Set-patron-branchcode-when-preparing-non.patch (text/plain), 1.68 KB, created by
Marcel de Rooy
on 2024-04-05 07:08:36 UTC
(
hide
)
Description:
Bug 23296: Set patron branchcode when preparing non-digest version
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-04-05 07:08:36 UTC
Size:
1.68 KB
patch
obsolete
>From 096e05800191d9004c2ff75ac6aaa0f543dd1b93 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 25 Jan 2024 21:54:21 +0000 >Subject: [PATCH] Bug 23296: Set patron branchcode when preparing non-digest > version >Content-Type: text/plain; charset=utf-8 > >To test: >1. APPLY PATCH >2. Set up circ rules to allow for auto renewals. >3. Set AutoRenewalNotices to 'according to message prefs' >4. Make a branch specific version of the the AUTO_RENEWAL notice. >5. Find a patron belonging to that branch and set the message prefs to allow for a AUTO_RENEWAL. But no digest option! >6. Check some things out and make sure they are eligble for auto renewal. >7. Run the cron. >8. Make sure the patron gets the branch specific notice. >9. Delete the branch specific notice. >10. DO 6-7 again. >11. Make sure they now get the all library notice. > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >[EDIT] Tidied one line. >--- > misc/cronjobs/automatic_renewals.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/misc/cronjobs/automatic_renewals.pl b/misc/cronjobs/automatic_renewals.pl >index f452fefc04..a08bbad34d 100755 >--- a/misc/cronjobs/automatic_renewals.pl >+++ b/misc/cronjobs/automatic_renewals.pl >@@ -251,6 +251,7 @@ if ( $send_notices && $confirm ) { > my $letter = C4::Letters::GetPreparedLetter ( > module => 'circulation', > letter_code => 'AUTO_RENEWALS', >+ branchcode => $patron->branchcode, > tables => { > borrowers => $patron->borrowernumber, > issues => $issue->itemnumber, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23296
:
161469
|
162127
| 164452