From 87e21d81cf20c997ea8c2e390e1411c0a9172c2b Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Wed, 10 Apr 2024 14:50:04 +0300 Subject: [PATCH] Bug 36567: Get rid of Datetime warning in Circulation.t and dateexpiry.t Running either t/db_dependent/Circulation.t or t/db_dependent/Circulation/dateexpiry.t cause following error to be dispalyed: You are creating a DateTime object with a far future year (9999) and a time zone (Europe/Helsinki). If the time zone you specified has future DST changes this will be very slow. Smallest allowed value is 4999, so we need to use that rather than 9999 in tests. To test prove t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t. Sponsored-by: Koha-Suomi Oy --- t/db_dependent/Circulation.t | 8 ++++---- t/db_dependent/Circulation/dateexpiry.t | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 5e88a29a00..f49b256e2a 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -2422,8 +2422,8 @@ subtest 'AddIssue & illrequests.due_date' => sub { set_userenv($library); - my $custom_date_due = '9999-12-18 12:34:56'; - my $expected_date_due = '9999-12-18 23:59:00'; + my $custom_date_due = '4999-12-18 12:34:56'; + my $expected_date_due = '4999-12-18 23:59:00'; my $illrequest = Koha::Illrequest->new({ borrowernumber => $patron->borrowernumber, biblio_id => $item->biblionumber, @@ -2436,8 +2436,8 @@ subtest 'AddIssue & illrequests.due_date' => sub { $patron = $builder->build_object( { class => 'Koha::Patrons' } ); $item = $builder->build_sample_item(); - $custom_date_due = '9999-12-19'; - $expected_date_due = '9999-12-19 23:59:00'; + $custom_date_due = '4999-12-19'; + $expected_date_due = '4999-12-19 23:59:00'; $illrequest = Koha::Illrequest->new({ borrowernumber => $patron->borrowernumber, biblio_id => $item->biblionumber, diff --git a/t/db_dependent/Circulation/dateexpiry.t b/t/db_dependent/Circulation/dateexpiry.t index 79ba9e0a02..f992219687 100755 --- a/t/db_dependent/Circulation/dateexpiry.t +++ b/t/db_dependent/Circulation/dateexpiry.t @@ -124,7 +124,7 @@ sub calc_date_due { is( ref $d eq "DateTime" && $d->mdy() =~ /^\d+/, 1, "CalcDateDue with expiry tomorrow" ); # fourth test far future - $patron->dateexpiry('9876-12-31')->store; + $patron->dateexpiry('4999-12-31')->store; my $t1 = time; $d = C4::Circulation::CalcDateDue( $today, $item->effective_itemtype, $branch->{branchcode}, $patron ); my $t2 = time; -- 2.34.1