Attachment 165357 Details for Bug 33024 – Bug 33024: (DO NOT PUSH): Test example

[patch] Bug 33024: (DO NOT PUSH): Test example

Bug-33024-DO-NOT-PUSH-Test-example.patch (text/plain), 2.86 KB, created by Matt Blenkinsop on 2024-04-23 08:52:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2024-04-23 08:52:18 UTC

Size: 2.86 KB

patch

obsolete

>From 7cd0454c101332ce43730b7e633467190d07ebba Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Tue, 23 Apr 2024 08:49:06 +0000
>Subject: [PATCH] Bug 33024: (DO NOT PUSH): Test example
>
>Apply patch, run yarn js:build
>The AgreementsShow and AgreementsFormAdd components are bundled separately, AgreementsList isn't but maybe that is an issue with it being the parent route?
>---
> koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js
>index 4f2331bdda..c294c1d929 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js
>@@ -1,9 +1,10 @@
> import { markRaw } from "vue";
> 
> import Home from "../components/ERM/Home.vue";
>-import AgreementsList from "../components/ERM/AgreementsList.vue";
>-import AgreementsShow from "../components/ERM/AgreementsShow.vue";
>-import AgreementsFormAdd from "../components/ERM/AgreementsFormAdd.vue";
>+const AgreementsList = () => import("../components/ERM/AgreementsList.vue");
>+const AgreementsShow = () => import("../components/ERM/AgreementsShow.vue");
>+const AgreementsFormAdd = () =>
>+    import("../components/ERM/AgreementsFormAdd.vue");
> import EHoldingsLocalPackagesFormAdd from "../components/ERM/EHoldingsLocalPackagesFormAdd.vue";
> import EHoldingsLocalTitlesFormAdd from "../components/ERM/EHoldingsLocalTitlesFormAdd.vue";
> import EHoldingsLocalTitlesFormImport from "../components/ERM/EHoldingsLocalTitlesFormImport.vue";
>@@ -51,24 +52,24 @@ export const routes = [
>                     {
>                         path: "",
>                         name: "AgreementsList",
>-                        component: markRaw(AgreementsList),
>+                        component: AgreementsList,
>                     },
>                     {
>                         path: ":agreement_id",
>                         name: "AgreementsShow",
>-                        component: markRaw(AgreementsShow),
>+                        component: AgreementsShow,
>                         title: $__("Show agreement"),
>                     },
>                     {
>                         path: "add",
>                         name: "AgreementsFormAdd",
>-                        component: markRaw(AgreementsFormAdd),
>+                        component: AgreementsFormAdd,
>                         title: $__("Add agreement"),
>                     },
>                     {
>                         path: "edit/:agreement_id",
>                         name: "AgreementsFormAddEdit",
>-                        component: markRaw(AgreementsFormAdd),
>+                        component: AgreementsFormAdd,
>                         title: $__("Edit agreement"),
>                     },
>                 ],
>-- 
>2.37.1 (Apple Git-137.1)

Actions: View | Diff | Splinter Review

Attachments on bug 33024: 165357