From 88ba6f13b3a5fb2d2d419bc43e35590d825b9e9f Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Fri, 12 Apr 2024 11:50:34 +0000
Subject: [PATCH] Bug 36246: (follow-up) Fix confirm

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 koha-tmpl/intranet-tmpl/prog/js/form-submit.js | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/js/form-submit.js b/koha-tmpl/intranet-tmpl/prog/js/form-submit.js
index 05625b8d8b5..dc19d1bb77a 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/form-submit.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/form-submit.js
@@ -5,12 +5,11 @@ $(document).ready(function(){
         let form_data = $(this).data();
 
         let confirm_msg = form_data.confirmationMsg;
-        let confirmation = 1;
         if( confirm_msg ){
+            let confirmation = confirm( confirm_msg );
+            if( !confirmation ){ return false; }
             delete form_data.confirmationMsg;
-            confirmation = confirm( confirm_msg );
         }
-        if( !confirmation ){ return false }
 
         let the_form = $('<form/>');
         if( form_data.method === 'post' ){
-- 
2.44.0