From 70f199a736280801998a064cb9f867d664c6aa85 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Wed, 1 May 2024 15:41:10 +0100 Subject: [PATCH] Bug 36120: (QA follow-up) Fix Circulation.t We now require pickup_library_id and so need to update the unit tests to reflect that for our sample bookings Signed-off-by: Nick Clemens --- t/db_dependent/Circulation.t | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 307db1d8a97..51387851e01 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -1763,6 +1763,7 @@ subtest "CanBookBeRenewed | bookings" => sub { my $renewing_patron = $builder->build_object( { class => 'Koha::Patrons' } ); my $booked_patron = $builder->build_object( { class => 'Koha::Patrons' } ); my $item = $builder->build_sample_item( { bookable => 1 } ); + my $pickup_library = $builder->build_object( { class => 'Koha::Libraries' } ); # issue my $issue = AddIssue( $renewing_patron, $item->barcode ); @@ -1772,11 +1773,12 @@ subtest "CanBookBeRenewed | bookings" => sub { # item-level booking my $booking = Koha::Booking->new( { - patron_id => $booked_patron->borrowernumber, - item_id => $item->itemnumber, - biblio_id => $item->biblio->biblionumber, - start_date => $datedue->clone()->add( days => 2 ), - end_date => $datedue->clone()->add( days => 10 ), + patron_id => $booked_patron->borrowernumber, + pickup_library_id => $pickup_library->branchcode, + item_id => $item->itemnumber, + biblio_id => $item->biblio->biblionumber, + start_date => $datedue->clone()->add( days => 2 ), + end_date => $datedue->clone()->add( days => 10 ), } )->store(); @@ -4746,18 +4748,20 @@ subtest 'CanBookBeIssued | bookings' => sub { my $schema = Koha::Database->schema; $schema->storage->txn_begin; - my $patron1 = $builder->build_object( { class => 'Koha::Patrons' } ); - my $patron2 = $builder->build_object( { class => 'Koha::Patrons' } ); - my $item = $builder->build_sample_item( { bookable => 1 } ); + my $patron1 = $builder->build_object( { class => 'Koha::Patrons' } ); + my $patron2 = $builder->build_object( { class => 'Koha::Patrons' } ); + my $pickup_library = $builder->build_object( { class => 'Koha::Libraries' } ); + my $item = $builder->build_sample_item( { bookable => 1 } ); # item-level booking my $booking = Koha::Booking->new( { - patron_id => $patron1->borrowernumber, - item_id => $item->itemnumber, - biblio_id => $item->biblio->biblionumber, - start_date => dt_from_string()->subtract( days => 1 ), - end_date => dt_from_string()->add( days => 6 ), + patron_id => $patron1->borrowernumber, + pickup_library_id => $pickup_library->branchcode, + item_id => $item->itemnumber, + biblio_id => $item->biblio->biblionumber, + start_date => dt_from_string()->subtract( days => 1 ), + end_date => dt_from_string()->add( days => 6 ), } )->store(); -- 2.44.0