Bugzilla – Attachment 166217 Details for
Bug 36792
Limit POSIX imports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36792: Limit POSIX imports
Bug-36792-Limit-POSIX-imports.patch (text/plain), 1.85 KB, created by
Marcel de Rooy
on 2024-05-06 12:17:42 UTC
(
hide
)
Description:
Bug 36792: Limit POSIX imports
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-05-06 12:17:42 UTC
Size:
1.85 KB
patch
obsolete
>From 4329d4c142f07e87d15dddd95750172836958ad6 Mon Sep 17 00:00:00 2001 >From: Janusz Kaczmarek <januszop@gmail.com> >Date: Mon, 6 May 2024 12:06:22 +0000 >Subject: [PATCH] Bug 36792: Limit POSIX imports >Content-Type: text/plain; charset=utf-8 > >A Marcel's QA patch to Bug 36552 added use POSIX; in two spots. >In https://metacpan.org/pod/POSIX we read: > >CAVEATS >Everything is exported by default (with a handful of exceptions). This is >an unfortunate backwards compatibility feature and its use is strongly >discouraged. You should either prevent the exporting (by saying use >POSIX ();, as usual) and then use fully qualified names (e.g. >POSIX::SEEK_END), or give an explicit import list. If you >do neither and opt for the default (as in use POSIX;), you will >import hundreds and hundreds of symbols into your namespace. > >This patch fixes this. > >No test plan. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > authorities/authorities.pl | 2 +- > cataloguing/addbiblio.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/authorities/authorities.pl b/authorities/authorities.pl >index 462098bc1e..e5150f7015 100755 >--- a/authorities/authorities.pl >+++ b/authorities/authorities.pl >@@ -21,7 +21,7 @@ > use Modern::Perl; > > use CGI qw ( -utf8 ); >-use POSIX; >+use POSIX qw( strftime ); > use C4::Auth qw( get_template_and_user ); > use C4::Output qw( output_html_with_http_headers ); > use C4::AuthoritiesMarc qw( AddAuthority ModAuthority GetAuthority GetTagsLabels GetAuthMARCFromKohaField FindDuplicateAuthority ); >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index d81215d486..3d92cdad1f 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -21,7 +21,7 @@ > > use Modern::Perl; > use CGI; >-use POSIX; >+use POSIX qw( strftime ); > use Try::Tiny qw(catch try); > > use C4::Output qw( output_html_with_http_headers ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36792
:
166216
| 166217