From 8708fe6b73f953c7b4a4e7b6415b921dfb3a50f5 Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Wed, 8 May 2024 06:42:21 -0400
Subject: [PATCH] Bug 31627: Remove new syspref SendLetterIdInEmailNotices

---
 installer/data/mysql/atomicupdate/bug_31627.pl     | 14 --------------
 installer/data/mysql/mandatory/sysprefs.sql        |  1 -
 .../prog/en/modules/admin/preferences/patrons.pref |  6 ------
 3 files changed, 21 deletions(-)
 delete mode 100755 installer/data/mysql/atomicupdate/bug_31627.pl

diff --git a/installer/data/mysql/atomicupdate/bug_31627.pl b/installer/data/mysql/atomicupdate/bug_31627.pl
deleted file mode 100755
index 52c5621dd8c..00000000000
--- a/installer/data/mysql/atomicupdate/bug_31627.pl
+++ /dev/null
@@ -1,14 +0,0 @@
-use Modern::Perl;
-
-return {
-    bug_number => "31627",
-    description => "Add syspref SendLetterIdInEmailNotices",
-    up => sub {
-        my ($args) = @_;
-        my ($dbh, $out) = @$args{qw(dbh out)};
-        $dbh->do(q{
-            INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
-            ('SendLetterIdInEmailNotices','0',NULL,'Add template id to bottom of emailed notices','YesNo')
-        });
-    },
-};
diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
index 219f6bf071b..833933da9ef 100644
--- a/installer/data/mysql/mandatory/sysprefs.sql
+++ b/installer/data/mysql/mandatory/sysprefs.sql
@@ -699,7 +699,6 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
 ('SelfCheckReceiptPrompt','1','NULL','If ON, print receipt dialog pops up when self checkout is finished','YesNo'),
 ('SelfCheckTimeout','120','','Define the number of seconds before the Web-based Self Checkout times out a patron','Integer'),
 ('SendAllEmailsTo','',NULL,'All emails will be redirected to this email if it is not empty','free'),
-('SendLetterIdInEmailNotices','0',NULL,'Add template id to bottom of emailed notices','YesNo'),
 ('SeparateHoldings','0',NULL,'Separate current branch holdings from other holdings','YesNo'),
 ('SeparateHoldingsBranch','homebranch','homebranch|holdingbranch','Branch used to separate holdings','Choice'),
 ('SerialsDefaultEmailAddress', '', NULL, 'Default email address used as reply-to for notices sent by the serials module.', 'Free'),
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
index a1e8f069899..0c280f302b7 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
@@ -184,12 +184,6 @@ Patrons:
                1: Notify
                0: "Don't notify"
          - patrons whenever their password is changed.
-     -
-         - pref: SendLetterIdInEmailNotices
-           choices:
-               1: Add
-               0: "Don't add"
-         - the template id for a notice to the bottom of any emailed notices.
      -
          - pref: UseEmailReceipts
            choices:
-- 
2.30.2