Bugzilla – Attachment 166542 Details for
Bug 34041
z3950 responder additional options not coming through properly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34041: (follow-up) escape double dashes to prevent issues
Bug-34041-follow-up-escape-double-dashes-to-preven.patch (text/plain), 1.58 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-05-10 12:36:06 UTC
(
hide
)
Description:
Bug 34041: (follow-up) escape double dashes to prevent issues
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-05-10 12:36:06 UTC
Size:
1.58 KB
patch
obsolete
>From e54b3ec531de90c7e36dc97757b43802ac4a33ea Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 10 May 2024 09:30:53 -0300 >Subject: [PATCH] Bug 34041: (follow-up) escape double dashes to prevent issues > >Having double dashes inside a commmented block is not valid XML. This >patch restores it, with an added message explaining it > >To test: >1. Run: > $ xmllint etc/z3950/config.xml >=> FAIL: You get: >etc/z3950/config.xml:5: parser error : Double hyphen within comment: <!-- > <config> > <z3950_responder_options> > <z3950_responder_options>--add-item-status k -t 5</z3950_responder_options >2. Apply this patch >3. Repeat 1 >=> SUCCESS: All good! > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > etc/z3950/config.xml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/etc/z3950/config.xml b/etc/z3950/config.xml >index 8f948f8665f..f909bac718d 100644 >--- a/etc/z3950/config.xml >+++ b/etc/z3950/config.xml >@@ -1,8 +1,10 @@ > <yazgfs> >- <!-- See z3950_responder.pl for available options. The options -c, -u and -p are already passed automatically by koha-z3950-responder --> >+ <!-- See z3950_responder.pl for available options. The options -c, -u and -p are >+ already passed automatically by koha-z3950-responder, note that dashes for the >+ add-item-status switch are escaped for XML compliance but should not if uncommented --> > <!-- > <config> >- <z3950_responder_options>--add-item-status k -t 5</z3950_responder_options> >+ <z3950_responder_options>\-\-add-item-status k -t 5</z3950_responder_options> > </config> > --> > >-- >2.45.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34041
:
152448
|
164150
|
164152
|
166540
| 166542