From df29e06252a2da5cce266ec87e2ad00d6a7c0f7c Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 6 May 2024 09:04:26 +0000 Subject: [PATCH] Bug 36785: Do not pass biblionumber to get_approval_rows Resolve: [WARN] get_approval_rows received unreconized argument key 'biblionumber'. at /usr/share/koha/opac/opac-tags.pl line 336. Test plan: Visit opac-tags.pl?biblionumber=SOME_NUMBER With this patch, you should no longer find a warning in the logs. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize --- opac/opac-tags.pl | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/opac/opac-tags.pl b/opac/opac-tags.pl index c346417e761..2c2fcfcdd88 100755 --- a/opac/opac-tags.pl +++ b/opac/opac-tags.pl @@ -332,11 +332,10 @@ if ($add_op) { my $arghash = {approved=>1, limit=>$limit, 'sort'=>'-weight_total'}; $arghash->{'borrowernumber'} = $loggedinuser if $mine; # ($openadds) or $arghash->{approved} = 1; - if ($arg = $query->param('tag')) { - $arghash->{term} = $arg; - } elsif ($arg = $query->param('biblionumber')) { - $arghash->{biblionumber} = $arg; - } + if ( $arg = $query->param('tag') ) { + $arghash->{term} = $arg; + } + # Bug 36785: Do not pass biblionumber: get_approval_rows does not 'recognize' biblionumber $results = get_approval_rows($arghash); stratify_tags(10, $results); # work out the differents sizes for things my $count = scalar @$results; -- 2.45.0