From 34da2c336c4d495d9b2795d5246c0dbeb972424f Mon Sep 17 00:00:00 2001
From: Fridolin Somers <fridolin.somers@biblibre.com>
Date: Wed, 29 Nov 2023 09:53:03 -1000
Subject: [PATCH] Bug 35442: Script migration_tools/build_oai_sets.pl add ORDER
 BY

Script migration_tools/build_oai_sets.pl is missing ORDER BY biblionumber.
This is a problem when using OFFSET and LIMIT, the results may be differenly orderder between two calls of this script.

Test plan :
1) Create a OAI SET with all records
2) Run migration_tools/build_oai_sets.pl with the first half of records
3) Run migration_tools/build_oai_sets.pl with the second half of records
4) Check all records are in the OAI set

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 misc/migration_tools/build_oai_sets.pl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/misc/migration_tools/build_oai_sets.pl b/misc/migration_tools/build_oai_sets.pl
index a312d3e0f9..24b842b4de 100755
--- a/misc/migration_tools/build_oai_sets.pl
+++ b/misc/migration_tools/build_oai_sets.pl
@@ -88,6 +88,7 @@ my $query = qq{
     FROM deletedbiblio_metadata
     WHERE format='marcxml'
     AND  `schema` = ?
+    ORDER BY biblionumber ASC
 };
 if($length) {
     $query .= "LIMIT $length";
-- 
2.39.2