From 076dbbee6ebaf39d60a81ab1c13a6bc35d3c2b91 Mon Sep 17 00:00:00 2001 From: Katariina Pohto Date: Tue, 21 May 2024 16:33:52 +0300 Subject: [PATCH] Bug 35771: Unselecting titles when making multi-hold When placing a hold on multiple biblios Place Holds page (request.pl) has checkboxes for unselecting some of the listed biblios. Removing the checkmark does not actually unselect the biblio. Clicking the Place holds button will place a hold for all the biblios on page that can be reserved. If unchecked biblio does not have a pickup location, it will get past form validation and cause an error. Test plan: 1. Select several biblios and choose Place hold 2. Choose a patron 3. Select a pickup location for all biblios and unselect one of the checkmarks 4. Place holds and note that even the deselected holds was placed. 5. Repeat steps 1-2. 6. Leave pickup locations empty and try to place the holds. 7. Note alert: "Please make sure all selected titles have a pickup location set" 8. Uncheck one of the biblios and add pickup locations to the checked biblios. 9. Try to place the holds and note that there is no alert, and you get an error 500. 10. Apply patch. 11. Repeat steps 1,2,8 and place holds. 12. Note that there is no error 500, and while all the biblios are shown on page, only the checked biblios have a new hold placed on them. --- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 7dca1e83ba..3ba6d5f6f5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -1063,7 +1063,6 @@ [% FOREACH biblioloo IN biblioloop %] [% UNLESS biblioloo.none_avail %] - [% END %] @@ -1126,7 +1125,7 @@ [% END %] [% UNLESS ( biblioloo.warn ) %] - + [% END %] -- 2.34.1