From a19057f55c82a0d3d83661935829aaf5d084a667 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 23 May 2024 08:49:39 +0200 Subject: [PATCH] Bug 36924: Remove warning "Value not allowed for auto_incr itemnumber in Item" Content-Type: text/plain; charset=utf-8 We are removing entirely the badly written test. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Note: We cannot test this properly when the search index refers to biblios and items that do not exist in the database. --- t/db_dependent/Search.t | 26 +------------------------- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/t/db_dependent/Search.t b/t/db_dependent/Search.t index 3beed6121c..00ce65abda 100755 --- a/t/db_dependent/Search.t +++ b/t/db_dependent/Search.t @@ -31,7 +31,6 @@ use Test::MockModule; use Test::Warn; use t::lib::Mocks; use t::lib::Mocks::Zebra; -use t::lib::TestBuilder; use Koha::Caches; @@ -703,29 +702,6 @@ ok(MARC::Record::new_from_xml($results_hashref->{biblioserver}->{RECORDS}->[0],' $results_hashref->{'biblioserver'}->{"RECORDS"}); is(scalar(@{$newresults[0]->{'ALTERNATEHOLDINGS'}}), 1, 'Alternate holdings filled in correctly'); - - ## Regression test for Bug 10741 - - # make one of the test items appear to be in transit - my $circ_module = Test::MockModule->new('C4::Circulation'); - my $builder = t::lib::TestBuilder->new; - my $transfer = $builder->build( - { - source => 'Branchtransfer', - value => { - itemnumber => 11, - frombranch => 'MPL', - tobranch => 'CPL', - datesent => \'NOW()' - } - } - ); - - ($error, $results_hashref, $facets_loop) = getRecords("TEST12121212","TEST12121212",[ ], [ 'biblioserver' ],20,0,\%branches,\%itemtypes,$query_type,0); - @newresults = searchResults({'interface'=>'intranet'}, $query_desc, $results_hashref->{'biblioserver'}->{'hits'}, 17, 0, 0, - $results_hashref->{'biblioserver'}->{"RECORDS"}); - ok(!exists($newresults[0]->{norequests}), 'presence of a transit does not block hold request action (bug 10741)'); - ## Regression test for bug 10684 ( undef, $results_hashref, $facets_loop ) = getRecords('ti:punctuation', 'punctuation', [], [ 'biblioserver' ], '19', 0, \%branches, \%itemtypes, 'ccl', undef); @@ -947,7 +923,7 @@ sub run_unimarc_search_tests { } subtest 'MARC21 + DOM' => sub { - plan tests => 94; + plan tests => 93; run_marc21_search_tests(); }; -- 2.30.2