Bugzilla – Attachment 167161 Details for
Bug 36916
TestBuilder generates incorrect JS and CSS for libraries
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36916: Do not generate invalid JS or CSS from TestBuilder
Bug-36916-Do-not-generate-invalid-JS-or-CSS-from-T.patch (text/plain), 1.79 KB, created by
Marcel de Rooy
on 2024-05-24 09:44:30 UTC
(
hide
)
Description:
Bug 36916: Do not generate invalid JS or CSS from TestBuilder
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-05-24 09:44:30 UTC
Size:
1.79 KB
patch
obsolete
>From e7d3cd62f1b0daff2a86d92d5249392b7c298460 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 22 May 2024 10:31:29 +0200 >Subject: [PATCH] Bug 36916: Do not generate invalid JS or CSS from TestBuilder >Content-Type: text/plain; charset=utf-8 > >TestBuilder generates random strings for branches.opacuserjs and branches.opacusercss which produces invalid JS and CSS. > >Selenium has several warnings related to this: > >koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-user.pl, line 1744: ReferenceError: CLYxPjQ152 is not defined >koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-search.pl, line 2069: ReferenceError: CLYxPjQ152 is not defined >koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-reserve.pl, line 1351: ReferenceError: CLYxPjQ152 is not defined > >Because of the following in the DOM > <script> > CLYxPjQ152 > </script> > >This patch suggests to set to an empty string by default, to prevent random failure or inconsistent behaviours when testing the UI. > >Test plan: >Run t/db_dependent/selenium/authentication.t and watch the selenium >output. >With this patch applied you will not see the "JavaScript error" lines > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/lib/TestBuilder.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm >index 630fab0cfb..57506b11d7 100644 >--- a/t/lib/TestBuilder.pm >+++ b/t/lib/TestBuilder.pm >@@ -624,6 +624,8 @@ sub _gen_default_values { > }, > Branch => { > pickup_location => 0, >+ opacuserjs => q{}, >+ opacusercss => q{}, > }, > Reserve => { > non_priority => 0, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36916
:
167011
|
167055
| 167161