From ebab1c06705aaa130dcc56d77ba33483efef33e1 Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Tue, 18 Jun 2024 14:15:32 +0000 Subject: [PATCH] Bug 36868: (follow-up) Fix staff interface code --- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++-- reserve/placerequest.pl | 3 ++- reserve/request.pl | 5 ++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index c3e0581043..f1fbca6db0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -1883,8 +1883,8 @@ [% END %] [% IF successful_holds && Koha.Preference('AutoDeleteFromCartWhenHoldPlaced').grep('staff').size %] - [% FOREACH biblionumber in successful_holds %] - delSingleRecord('[% biblionumber | html %]'); + [% FOREACH success IN successful_holds.split('\|') %] + delSingleRecord('[% success | html %]'); [% END %] [% END %] diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl index 8bc4391fba..8b9dcad010 100755 --- a/reserve/placerequest.pl +++ b/reserve/placerequest.pl @@ -168,7 +168,8 @@ if ( $op eq 'cud-placerequest' && $patron ) { foreach my $msg ( keys %failed_holds ) { push( @failed_hold_msgs, $msg ); } - $redirect_url->query_form( biblionumber => [@biblionumbers], failed_holds => \@failed_hold_msgs, successful_holds => \@successful_biblionumbers, ); + $redirect_url->query_form( biblionumber => [@biblionumbers], failed_holds => \@failed_hold_msgs ); + $redirect_url .= "&successful_holds=" . join('|', @successful_biblionumbers); print $input->redirect($redirect_url); } elsif ( $borrowernumber eq '' ) { diff --git a/reserve/request.pl b/reserve/request.pl index 7992f2a7ea..a36ce023a2 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -89,7 +89,7 @@ my $messages; my $exceeded_maxreserves; my $exceeded_holds_per_record; my @failed_holds = $input->multi_param('failed_holds'); -my @successful_holds = $input->multi_param('successful_holds'); +my @successful_holds = $input->param('successful_holds'); my $op = $input->param('op') || q{}; if ( $op eq 'cud-move' ) { @@ -722,8 +722,7 @@ $template->param( biblionumbers => \@biblionumbers ); $template->param( pickup => $pickup || C4::Context->userenv->{branch} ); $template->param(borrowernumber => $borrowernumber_hold); - -$template->param( failed_holds => \@failed_holds, successful_holds => \@successful_holds ); +$template->param( failed_holds => \@failed_holds, successful_holds => @successful_holds ); # printout the page output_html_with_http_headers $input, $cookie, $template->output; -- 2.39.2