From b890de8f3f8bbec3a0bc0f8b152a2505a76f9e0d Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 26 Jun 2024 14:56:58 +0000 Subject: [PATCH] Bug 37187: Fix deletion of label batches and label templates Content-Type: text/plain; charset=utf-8 This patch uses the new form-submit JS to convert the label management deletion link from a GET operation to POST. To test, apply the patch and go to Cataloging -> Label creator. - Click Manage -> Label batches. Create a batch if necessary. - Click the "Delete" button in the "Actions" column. You should get a confirmation message, "Are you sure you want to delete this?" - Test both the confirming and cancelling. - Perform the same test with Manage -> Label templates. - From the Manage -> Label batches page, click "edit" on one of the batches. - Right above the "Items in batch number X" is a toolbar which should have a button, "Delete batch." Test that it works correctly to delete the batch. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda Signed-off-by: Marcel de Rooy --- .../en/modules/labels/label-edit-batch.tt | 20 +++++-------------- .../prog/en/modules/labels/label-manage.tt | 4 +++- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt index 73855dbef5..ddf93049e0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt @@ -124,7 +124,9 @@ Add item(s)[% IF ( table_loop ) %] Save description Remove selected items - Delete batch + + Delete batch + Remove duplicates Export selected items Export full batch[% END %] @@ -206,17 +208,8 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'greybox.inc' %] [% INCLUDE 'datatables.inc' %] + [% Asset.js("js/form-submit.js") | $raw %]