Bugzilla – Attachment 16828 Details for
Bug 9912
DateUtils.t must not access database
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9912: DateUtils.t must not access database
Bug-9912-DateUtilst-must-not-access-database.patch (text/plain), 1.77 KB, created by
Jared Camins-Esakov
on 2013-03-23 13:12:43 UTC
(
hide
)
Description:
Bug 9912: DateUtils.t must not access database
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2013-03-23 13:12:43 UTC
Size:
1.77 KB
patch
obsolete
>From 98c1f4aae3c69dc1cc4231c159273b70e241aa80 Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Sat, 23 Mar 2013 09:08:05 -0400 >Subject: [PATCH] Bug 9912: DateUtils.t must not access database > >--- > t/DateUtils.t | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/t/DateUtils.t b/t/DateUtils.t >index 8890cea..eab8424 100755 >--- a/t/DateUtils.t >+++ b/t/DateUtils.t >@@ -29,7 +29,9 @@ cmp_ok $date_string, 'eq', '2011-06-16 12:00', 'iso output'; > $date_string = output_pref( $dt, 'iso', '12hr' ); > cmp_ok $date_string, 'eq', '2011-06-16 12:00 PM', 'iso output 12hr'; > >-$date_string = output_pref( $dt, 'iso', undef, 1 ); >+# "notime" doesn't actually mean anything in this context, but we >+# can't pass undef or output_pref will try to access the database >+$date_string = output_pref( $dt, 'iso', 'notime', 1 ); > cmp_ok $date_string, 'eq', '2011-06-16', 'iso output (date only)'; > > $date_string = output_pref( $dt, 'us', '24hr' ); >@@ -38,14 +40,14 @@ cmp_ok $date_string, 'eq', '06/16/2011 12:00', 'us output'; > $date_string = output_pref( $dt, 'us', '12hr' ); > cmp_ok $date_string, 'eq', '06/16/2011 12:00 PM', 'us output 12hr'; > >-$date_string = output_pref( $dt, 'us', undef, 1 ); >+$date_string = output_pref( $dt, 'us', 'notime', 1 ); > cmp_ok $date_string, 'eq', '06/16/2011', 'us output (date only)'; > > # metric should return the French Revolutionary Calendar Really > $date_string = output_pref( $dt, 'metric', '24hr' ); > cmp_ok $date_string, 'eq', '16/06/2011 12:00', 'metric output'; > >-$date_string = output_pref( $dt, 'metric', undef, 1 ); >+$date_string = output_pref( $dt, 'metric', 'notime', 1 ); > cmp_ok $date_string, 'eq', '16/06/2011', 'metric output (date only)'; > > $date_string = output_pref_due( $dt, 'metric', '24hr' ); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9912
: 16828