From c08711c63bc6b5ed4ec9863e1009daaa3b2648b8 Mon Sep 17 00:00:00 2001
From: Lucas Gass <lucas@bywatersolutions.com>
Date: Mon, 1 Jul 2024 17:14:47 +0000
Subject: [PATCH] Bug 23674: Fix duplicate ID's and label

---
 .../prog/en/modules/members/boraccount.tt          | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
index efd45ca9fa..f4d088f619 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
@@ -304,7 +304,7 @@
                         <fieldset class="rows">
                             <ol>
                                 <li>
-                                    <span id="item" class="label">Account: </span><span></span>
+                                    <span id="refund_item" class="label">Account: </span><span></span>
                                 </li>
                                 <li>
                                     <span id="paid" class="label">Amount paid: </span><span></span>
@@ -359,7 +359,7 @@
                         <fieldset class="rows">
                             <ol>
                                 <li>
-                                    <span id="item" class="label">Account type: </span><span></span>
+                                    <span id="apply_discount_item" class="label">Account type: </span><span></span>
                                 </li>
                                 <li>
                                     <span id="charged" class="label">Amount charged: </span><span></span>
@@ -402,7 +402,7 @@
                         <fieldset class="rows">
                             <ol>
                                 <li>
-                                    <label for="apply_discount_note">Note: </label>
+                                    <label for="void_note">Note: </label>
                                     <input type="text" id="void_note" name="void_note">
                                 </li>
                             </ol>
@@ -516,7 +516,7 @@
             $("#applyDiscountModal").on("shown.bs.modal", function(e){
                 var button = $(e.relatedTarget);
                 var item = button.data('item');
-                $("#item + span").replaceWith(item);
+                $("#apply_discount_item + span").replaceWith(item);
                 var accountline = button.data('accountline');
                 $('#discountline').val(accountline);
                 var amount = button.data('amount');
@@ -527,10 +527,8 @@
 
             $("#voidPaymentModal").on("shown.bs.modal", function(e){
                 var button = $(e.relatedTarget);
-                var item = button.data('item');
-                $("#item + span").replaceWith(item);
-                var accountline = button.data('accountline');
-                $('#voidline').val(accountline);
+                var item = button.data('accountline');
+                $('#voidline').val(item);
             });
 
             $("#cancelChargeModal").on("shown.bs.modal", function(e){
-- 
2.39.2