Bugzilla – Attachment 168485 Details for
Bug 37252
Saving an authority record as MADS (XML) fails
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37252: Use our local copy of MARC21slimUtils.xsl in MARC21slim2MADS.xsl
Bug-37252-Use-our-local-copy-of-MARC21slimUtilsxsl.patch (text/plain), 3.75 KB, created by
David Nind
on 2024-07-04 00:58:27 UTC
(
hide
)
Description:
Bug 37252: Use our local copy of MARC21slimUtils.xsl in MARC21slim2MADS.xsl
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-07-04 00:58:27 UTC
Size:
3.75 KB
patch
obsolete
>From 9b4d5e22b0bc4ae2b6c6b6b5c3f2fd796dbee069 Mon Sep 17 00:00:00 2001 >From: Phil Ringnalda <phil@chetcolibrary.org> >Date: Wed, 3 Jul 2024 14:16:36 -0700 >Subject: [PATCH] Bug 37252: Use our local copy of MARC21slimUtils.xsl in > MARC21slim2MADS.xsl > >Our local copy of the Library of Congress stylesheet MARC21slim2MADS.xsl is >our only one which includes MARC21slimUtils.xsl directly from the Library of >Congress rather than including our local copy. That makes it a fragile canary >for whatever reason that it currently isn't loading, but because it's not >exactly the most popular menu choice in all of Koha, it's far from being one >that anyone will notice. > >We should instead include our local copy, make the bug 29556 change to >MARC21slim2MADS.xsl, and if someone wants to notice when including xsl from >LoC fails, they should write a test for it rather than depend on someone >noticing that saving authority records as MADS fails. > >Test plan: >1. Without the patch, Authorities - search for Smith - click the linked > name of any result to show authorities/detail.pl >2. Save - MADS (XML) >3. Check your downloaded file, see that it is zero bytes >4. Apply patch, restart_all >5. Repeat step 2, but this time find that your downloaded file is more > than zero bytes. > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/en/xslt/MARC21slim2MADS.xsl | 33 +------------------ > 1 file changed, 1 insertion(+), 32 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl >index a7dc31e2e1..8c56426090 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl >@@ -6,7 +6,7 @@ > xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:marc="http://www.loc.gov/MARC21/slim" > xmlns:xsl="http://www.w3.org/1999/XSL/Transform" exclude-result-prefixes="marc"> > >- <xsl:include href="http://www.loc.gov/marcxml/xslt/MARC21slimUtils.xsl"/> >+ <xsl:include href="MARC21slimUtils.xsl"/> > <xsl:output method="xml" indent="yes" encoding="UTF-8"/> > <xsl:strip-space elements="*"/> > <!-- Stylesheet copyright (c) 2011 Library of Congress >@@ -320,37 +320,6 @@ > </xsl:template> > --> > >- <xsl:template name="part"> >- <xsl:variable name="partNumber"> >- <xsl:call-template name="specialSubfieldSelect"> >- <xsl:with-param name="axis">n</xsl:with-param> >- <xsl:with-param name="anyCodes">n</xsl:with-param> >- <xsl:with-param name="afterCodes">fghkdlmor</xsl:with-param> >- </xsl:call-template> >- </xsl:variable> >- <xsl:variable name="partName"> >- <xsl:call-template name="specialSubfieldSelect"> >- <xsl:with-param name="axis">p</xsl:with-param> >- <xsl:with-param name="anyCodes">p</xsl:with-param> >- <xsl:with-param name="afterCodes">fghkdlmor</xsl:with-param> >- </xsl:call-template> >- </xsl:variable> >- <xsl:if test="string-length(normalize-space($partNumber))"> >- <mads:partNumber> >- <xsl:call-template name="chopPunctuation"> >- <xsl:with-param name="chopString" select="$partNumber"/> >- </xsl:call-template> >- </mads:partNumber> >- </xsl:if> >- <xsl:if test="string-length(normalize-space($partName))"> >- <mads:partName> >- <xsl:call-template name="chopPunctuation"> >- <xsl:with-param name="chopString" select="$partName"/> >- </xsl:call-template> >- </mads:partName> >- </xsl:if> >- </xsl:template> >- > <xsl:template name="nameABCDN"> > <xsl:for-each select="marc:subfield[@code='a']"> > <mads:namePart> >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37252
:
168479
|
168485
|
168555