From e255d9921723bb84230861b80d242dbe244a8485 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 10 Jul 2024 15:00:21 +0200 Subject: [PATCH] Bug 37301: Restore to For discussion. I quite liked it, we didn't need an extra method. The problem I can see is that edit and add behave differently that delete. Is that a problem? If we drop this patch we need to decide a better wording: editAgreement is IMO the action of editing an agreement. Here I think we need maybe goToEditResourceForm and goToAddResourceform for the event names. --- .../prog/js/vue/components/ERM/AgreementsList.vue | 7 +------ .../prog/js/vue/components/ERM/AgreementsShow.vue | 14 +++++++------- .../prog/js/vue/components/ToolbarButton.vue | 14 ++++++++------ 3 files changed, 16 insertions(+), 19 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue index 07d3e5c7ba8..a702c89f882 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue @@ -4,7 +4,7 @@ @@ -174,11 +174,6 @@ export default { error => {} ) }, - add_agreement: function () { - this.$router.push({ - name: "AgreementsFormAdd", - }) - }, doShow: function ({ agreement_id }, dt, event) { event.preventDefault() this.$router.push({ diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue index 75b8cd72306..ef35203a1fd 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue @@ -2,7 +2,13 @@
{{ $__("Loading") }}
- + @@ -383,12 +389,6 @@ export default { error => {} ) }, - edit_agreement: function () { - this.$router.push({ - name: "AgreementsFormAddEdit", - params: { agreement_id: this.agreement.agreement_id }, - }) - }, delete_agreement: function () { let agreement_id = this.agreement.agreement_id let agreement_name = this.agreement.name diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue index d6c535284fc..4b35e346782 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue @@ -1,5 +1,5 @@