From d02f9393d9a8fe628058471dea556e146b3bef05 Mon Sep 17 00:00:00 2001
From: Jan Kissig <jkissig@th-wildau.de>
Date: Mon, 15 Jul 2024 13:01:39 +0200
Subject: [PATCH] Bug 37324: Self registration complete login form won't login
 user

This patch fixes the self registration complete login form which appears after a complete self registration process.

To test:
a) open http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronSelfRegistrationDefaultCategory
b) set PatronSelfRegistration to allow
c) set PatronSelfRegistrationDefaultCategory to Self registration
d) logout or open a private tab
e) http://localhost:8080/cgi-bin/koha/opac-memberentry.pl and enter required fields
f) Registration complete! appears with a prefilled login form. Click Log in.
g) Check you are not logged in

apply patch and redo steps e-f and check that login worked.

Signed-off-by: David Nind <david@davidnind.com>
---
 .../en/modules/opac-registration-confirmation.tt         | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt
index 3c62811082..6fef58e72a 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt
@@ -106,19 +106,20 @@
                                 <form action="/cgi-bin/koha/opac-user.pl" method="post" name="auth" id="auth" autocomplete="off">
                                     [% INCLUDE 'csrf-token.inc' %]
                                     <input type="hidden" name="koha_login_context" value="opac" />
+                                    <input type="hidden" name="op" value="cud-login">
                                     <fieldset class="brief">
                                         <legend>Log in to your account:</legend>
                                         <label for="userid">Login:</label>
                                         [% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %]
-                                            <input class="form-control" type="text" id="userid" size="10" name="userid" value="[% borrower.userid | html %]" autocomplete="off" />
+                                            <input class="form-control" type="text" id="userid" size="10" name="login_userid" value="[% borrower.userid | html %]" autocomplete="off" />
                                         [% ELSE %]
-                                            <input class="form-control" type="text" id="userid" size="10" name="userid" value="" autocomplete="off" />
+                                            <input class="form-control" type="text" id="userid" size="10" name="login_userid" value="" autocomplete="off" />
                                         [% END %]
                                         <label for="password">Password:</label>
                                         [% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %]
-                                            <input class="form-control" type="password" id="password" size="10" name="password" value="[% password_cleartext | html %]" autocomplete="off" />
+                                            <input class="form-control" type="password" id="password" size="10" name="login_password" value="[% password_cleartext | html %]" autocomplete="off" />
                                         [% ELSE %]
-                                            <input class="form-control" type="password" id="password" size="10" name="password" value="" autocomplete="off" />
+                                            <input class="form-control" type="password" id="password" size="10" name="login_password" value="" autocomplete="off" />
                                         [% END %]
                                     <fieldset class="action">
                                         <input type="submit" value="Log in" class="btn btn-primary" />
-- 
2.39.2