From d6c189a1ccefc292f684823ff07b30da35e90fa0 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Mon, 25 Mar 2013 09:34:33 -0400 Subject: [PATCH] Bug 9922 - holds queue shows home library with AutomaticReturn Test Plan: 1) Enable AutomaticItemReturn 2) Place a reserve on an item where the holding and home branches differ 3) Rebuild the holds queue 4) Check the holds queue, verify the item is listed in the items to pull for the item's home branch 5) Disable AutomaticItemReturn 6) Rebuild the holds queue 7) Verify the item is listed in the items to pull for the item's holding branch 8) Enable AutomaticItemReturn 9) Apply patch 10) Rebuild the holds queue 11) Verify the item is listed in the items to pull for the item's holding branch Signed-off-by: Liz Rea Tested per plan, and the patch seems sane. Functionality of the hold queue is restored to previous behaviour. --- C4/HoldsQueue.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm index 7d38963..655269b 100755 --- a/C4/HoldsQueue.pm +++ b/C4/HoldsQueue.pm @@ -400,8 +400,7 @@ sub MapItemsToHoldRequests { foreach my $item (@$available_items) { next unless $item->{holdallowed}; - push @{ $items_by_branch{ $automatic_return ? $item->{homebranch} - : $item->{holdingbranch} } }, $item + push @{ $items_by_branch{ $item->{holdingbranch} } }, $item unless exists $allocated_items{ $item->{itemnumber} }; } return unless keys %items_by_branch; -- 1.7.9.5