From e6735fde8590af041b107f85443c9e50a9a3e2d6 Mon Sep 17 00:00:00 2001 From: Petro Vashchuk Date: Wed, 24 Jul 2024 07:30:43 +0300 Subject: [PATCH] Bug 37444: Fix filter for Pickup Location When trying to filter holds to pull using the dropdown filter for Pickup Location, the dropdown has "None" as the only available option because of incorrect column index in ppendingreserves.tt To reproduce: 1. Place a hold and go to Circulation -> Holds to pull. 2. Use a dropdown filter for Pickup Location, see that only "None" is available to pick, meaning you can't use the filter. 3. Apply the patch. 4. Do the step 2 again and ensure that there's also an option for that hold's pickup location. --- .../intranet-tmpl/prog/en/modules/circ/pendingreserves.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt index 8709b5bf07..2b7b2c490f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt @@ -380,9 +380,9 @@ }); }); $("#pickup-location").each( function () { - $(this).html( createSelect( holdst.fnGetColumnData(14) ) ); + $(this).html( createSelect( holdst.fnGetColumnData(15) ) ); $('select', this).change( function () { - holdst.fnFilter( $(this).val(), 14 ); + holdst.fnFilter( $(this).val(), 15 ); }); }); }); -- 2.44.0