From 4a492e7df1beef6283ba2b8f70495480b73363ee Mon Sep 17 00:00:00 2001 From: Laura_Escamilla Date: Wed, 24 Jul 2024 21:31:02 +0000 Subject: [PATCH] Bug 30519: Show Checkin box even if CircConfirmParts is enabled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To test: 1. Set the system preference CircConfirmItemParts to require confirmation 2. Add a materials specified note to an item. 3. Check the item out to a patron, confirming the note. 4. Go to patron record, either moremember or circulation 5. Using the Check In column, attempt to check in the item. Notice no confirmation box, and item is not checked in. 6. Apply the patch and restart_all. Also clear your cache. 7. Make sure you have the item with the material specified note still checked out. 8. The Check In column now shows a visible checkin box. Next to the checkin box you will see the material specified note. 9. Click on the checkin box. The “Check in selected items” button now becomes usable. Click on it and notice that the item is now successfully checked in. 10. Sign off and have an amazing day! :D Signed-off-by: Andrew Fuerste-Henry --- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js index a2b540e971..88fe5afd7f 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js +++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js @@ -367,10 +367,12 @@ function LoadIssuesTable() { return "" + __("Recalled") + ""; } else if ( oObj.can_renew_error == "on_reserve" ) { return "" + __("On hold") + ""; - } else if ( oObj.materials ) { - return __("Confirm (%s)".format(oObj.materials.escapeHtml())); } else { - return ""; + var content = ""; + if (oObj.materials) { + content += __("Confirm (%s)").format(oObj.materials.escapeHtml()); + } + return content; } } }, -- 2.39.2