Bugzilla – Attachment 16996 Details for
Bug 9922
holds queue shows home library with AutomaticReturn
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 9922 - holds queue shows home library with AutomaticReturn
PASSED-QA-Bug-9922---holds-queue-shows-home-librar.patch (text/plain), 1.82 KB, created by
Katrin Fischer
on 2013-03-29 08:05:07 UTC
(
hide
)
Description:
[PASSED QA] Bug 9922 - holds queue shows home library with AutomaticReturn
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-03-29 08:05:07 UTC
Size:
1.82 KB
patch
obsolete
>From 6c002ed3e0845692b3a8599c97db09b0e9b9d811 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 25 Mar 2013 09:34:33 -0400 >Subject: [PATCH] [PASSED QA] Bug 9922 - holds queue shows home library with > AutomaticReturn > >Test Plan: > 1) Enable AutomaticItemReturn > 2) Place a reserve on a record where the holding and home branches differ > for the available items > 3) Rebuild the holds queue > 4) Check the holds queue, verify the item is listed in the items to pull for the item's home branch > 5) Disable AutomaticItemReturn > 6) Rebuild the holds queue > 7) Verify the item is listed in the items to pull for the item's holding branch > 8) Enable AutomaticItemReturn > 9) Apply patch >10) Rebuild the holds queue >11) Verify the item is listed in the items to pull for the item's holding branch > >Signed-off-by: Liz Rea <liz@catalyst.net.nz> >Tested per plan, and the patch seems sane. Functionality of the hold queue is restored to previous behaviour. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Amended test plan to make clear it has to be a record level >hold for the test plan to work. >All tests and QA script pass. >--- > C4/HoldsQueue.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index 7d38963..655269b 100755 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -400,8 +400,7 @@ sub MapItemsToHoldRequests { > foreach my $item (@$available_items) { > next unless $item->{holdallowed}; > >- push @{ $items_by_branch{ $automatic_return ? $item->{homebranch} >- : $item->{holdingbranch} } }, $item >+ push @{ $items_by_branch{ $item->{holdingbranch} } }, $item > unless exists $allocated_items{ $item->{itemnumber} }; > } > return unless keys %items_by_branch; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9922
:
16855
|
16922
| 16996