From 3b30868b1d0ccfa149dbd4f1b949700619dbb5dc Mon Sep 17 00:00:00 2001
From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Date: Wed, 3 Jul 2024 15:59:33 +0000
Subject: [PATCH] Bug 24471: Rename handle_commit_maybe method
Content-Type: text/plain; charset=utf-8

To test (k-t-d):
1) Enable ILLModule and install FreeForm, run:
  bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Checkout 24.05.x branch, run:
  cd /kohadevbox/koha/Koha/Illbackends/FreeForm
  git checkout 24.05.x
3) Create a new ILL request from:
  http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
4) Confirm the request creation works as before

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
---
 ill/ill-requests.pl | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl
index 3fac879dd4..4abde0fdb8 100755
--- a/ill/ill-requests.pl
+++ b/ill/ill-requests.pl
@@ -157,7 +157,7 @@ if ( $backends_available ) {
                 whole     => $backend_result,
                 request   => $request
             );
-            handle_commit_maybe($backend_result, $request);
+            redirect_user($backend_result, $request);
         }
     } elsif ( $op eq 'migrate' ) {
         # We're in the process of migrating a request
@@ -187,7 +187,7 @@ if ( $backends_available ) {
                 request => $request
             );
         }
-        handle_commit_maybe( $backend_result, $request );
+        redirect_user( $backend_result, $request );
 
     } elsif ( $op eq 'confirm' ) {
         # Backend 'confirm' method
@@ -200,7 +200,7 @@ if ( $backends_available ) {
         );
 
         # handle special commit rules & update type
-        handle_commit_maybe($backend_result, $request);
+        redirect_user($backend_result, $request);
 
     } elsif ( $op eq 'cud-cancel' ) {
         # Backend 'cancel' method
@@ -213,7 +213,7 @@ if ( $backends_available ) {
         );
 
         # handle special commit rules & update type
-        handle_commit_maybe($backend_result, $request);
+        redirect_user($backend_result, $request);
 
     } elsif ( $op eq 'cud-edit_action' ) {
         $op =~ s/^cud-//;
@@ -279,7 +279,7 @@ if ( $backends_available ) {
                     next    => 'illlist',
                     value   => {}
                 };
-                handle_commit_maybe( $backend_result, $request );
+                redirect_user( $backend_result, $request );
             }
         }
 
@@ -321,7 +321,7 @@ if ( $backends_available ) {
         );
 
         # handle special commit rules & update type
-        handle_commit_maybe($backend_result, $request);
+        redirect_user($backend_result, $request);
 
     } elsif ( $op eq 'cud-generic_confirm' ) {
         $op =~ s/^cud-//;
@@ -383,7 +383,7 @@ if ( $backends_available ) {
         };
 
         # handle special commit rules & update type
-        handle_commit_maybe($backend_result, $request);
+        redirect_user($backend_result, $request);
     } elsif ( $op eq 'cud-check_out') {
         $op =~ s/^cud-//;
         my $request = Koha::ILL::Requests->find($params->{illrequest_id});
@@ -471,7 +471,7 @@ if ( $backends_available ) {
         );
 
         # handle special commit rules & update type
-        handle_commit_maybe($backend_result, $request);
+        redirect_user($backend_result, $request);
     }
 }
 
@@ -484,7 +484,7 @@ $template->param(
 
 output_html_with_http_headers( $cgi, $cookie, $template->output );
 
-sub handle_commit_maybe {
+sub redirect_user {
     my ( $backend_result, $request ) = @_;
 
     # We need to special case 'commit'
-- 
2.30.2