From f689a3bafe2d276853c13d8253cd570e8260fe82 Mon Sep 17 00:00:00 2001 From: Phil Ringnalda Date: Fri, 9 Aug 2024 15:43:50 -0700 Subject: [PATCH] Bug 37612: Batch patron modification should accept both cud-show and show ops Just like with batch item modification, batch patron modification can accept either a POST of a lot of data, which might be more than Apache's default URL length limit, or a GET of a little data. Or at least it could, if both the op 'cud-show' and the op 'show' were accepted. Show isn't doing any creation or updating or deleting, it just has to be cud-show because it needs to be able to accept large POSTs. So when it is only getting a little data, it should be willing to take a GET with op=show just like batch item modification does. Test plan: 1. Tools - Patron lists - New patron list - give it a name and Save 2. Type enough characters in the Patron search input to find a patron (I like ace for poor often-used Henry Acevedo) 3. Add patrons 4. Return to Patron lists, and in the Actions menu for your list, choose Batch edit patrons. Note that the page that loads doesn't show any patrons or UI to edit them, only a message about "No patron card numbers or borrowernumbers given." 5. Apply patch, restart_all 6. Repeat step 4, but this time get a page with your patron listed, and a form to change things about the patron record. --- tools/modborrowers.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl index 502c1e0fa5..fabf4ae091 100755 --- a/tools/modborrowers.pl +++ b/tools/modborrowers.pl @@ -56,7 +56,7 @@ $template->param( CanUpdatePasswordExpiration => 1 ) if $logged_in_user->is_supe my $dbh = C4::Context->dbh; # Show borrower informations -if ( $op eq 'cud-show' ) { +if ( $op eq 'cud-show' || $op eq 'show' ) { my @borrowers; my @patronidnumbers; my @notfoundcardnumbers; -- 2.44.0